Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tibber] Add accumulatedReward channel #14277

Merged
merged 7 commits into from
Jan 27, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Jan 25, 2023

  • Adds channel for accumulatedReward

3.4.2: https://1drv.ms/u/s!AnMcxmvEeupwjqVH4mkQC4BrMOPcgw?e=GkFr43
4.0.0: https://1drv.ms/u/s!AnMcxmvEeupwjqVGznHUFOHls71Icw?e=HpEtvr

Tested and confirmed working.

Resolves: #12273

@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Jan 25, 2023
@lsiepel lsiepel requested a review from a team January 25, 2023 21:13
@lsiepel lsiepel requested a review from kjoglum as a code owner January 25, 2023 21:13
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: lsiepel <leosiepel@gmail.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new channel. LGTM.

@jlaur jlaur merged commit 865c4b8 into openhab:main Jan 27, 2023
@jlaur jlaur added this to the 4.0 milestone Jan 27, 2023
@lsiepel lsiepel deleted the tibber-channel-reward branch January 27, 2023 17:16
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* Add channel, fix warning

Signed-off-by: lsiepel <leosiepel@gmail.com>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
* Add channel, fix warning

Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
* Add channel, fix warning

Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tibber] Missing channel for accumulatedReward (from Live API)
2 participants