Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onewire] Code improvements and bug fixes #14400

Merged
merged 3 commits into from
Feb 16, 2023
Merged

[onewire] Code improvements and bug fixes #14400

merged 3 commits into from
Feb 16, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 15, 2023

@J-N-K
[onewire] Code improvements and bug fixes
a721726 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on labels Feb 15, 2023
@J-N-K J-N-K requested a review from a team as a code owner February 15, 2023 23:37
@J-N-K
fixes
35cb20d 
Signed-off-by: Jan N. Klug <github@klug.nrw>
jlaur
jlaur requested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Only a small comment about I18N texts.

bundles/org.openhab.binding.onewire/src/main/resources/OH-INF/thing/common.xml Show resolved Hide resolved
@J-N-K
address review comments
a2de736 
Signed-off-by: Jan N. Klug <github@klug.nrw>
jlaur
jlaur approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 5ea0dcb into openhab:main Feb 16, 2023
@jlaur jlaur added this to the 4.0 milestone Feb 16, 2023
@jlaur jlaur mentioned this pull request Feb 16, 2023
Closed
@J-N-K J-N-K deleted the onewire branch February 16, 2023 17:57
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@J-N-K @nemerdaud
[onewire] Code improvements and bug fixes (openhab#14400)
02b0e3c 
Signed-off-by: Jan N. Klug <github@klug.nrw>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@J-N-K @renescherer
[onewire] Code improvements and bug fixes (openhab#14400)
cc34e9c 
Signed-off-by: Jan N. Klug <github@klug.nrw>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@J-N-K @FordPrfkt
[onewire] Code improvements and bug fixes (openhab#14400)
9574d24 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@lolodomo lolodomo mentioned this pull request May 5, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@J-N-K @jlaur