[atlona] Add support for AT-PRO3HD44M #14080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
mlobstein
added
the
enhancement
|
Would it be needed to re-create the thing because the channel type changed ? to make use of the system provided ones? If so this is a breaking change. |
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
That is a good point. I don't think it warrants the trouble so I reverted those changes. |
|
As 4.0.0 is a release that is gonna break more stuff, this is the right moment to make such changes. Using the system channel type is an improvement. |
borazslo
pushed a commit
to borazslo/openhab-mideaac-addon
that referenced
this pull request
Jan 8, 2023
* Add support for AT-PRO3HD44M Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Add support for AT-PRO3HD44M Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* Add support for AT-PRO3HD44M Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #9385
Add support for the older model AT-PRO3HD44M 4x4 matrix that uses the same protocol as the AT-PRO3HD66M matrix. Also fix binding name to follow standard naming conventions.