[atlona] Add support for the AT-PRO3HD66M #9385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
cpmeister
added
the
enhancement
J-N-K
requested changes
Dec 24, 2020
...b.binding.atlona/src/main/java/org/openhab/binding/atlona/internal/AtlonaHandlerFactory.java
Outdated
Show resolved
Hide resolved
...b.binding.atlona/src/main/java/org/openhab/binding/atlona/internal/AtlonaHandlerFactory.java
Outdated
Show resolved
Hide resolved
...atlona/src/main/java/org/openhab/binding/atlona/internal/pro3/AtlonaPro3PortocolHandler.java
Show resolved
Hide resolved
...atlona/src/main/java/org/openhab/binding/atlona/internal/pro3/AtlonaPro3PortocolHandler.java
Show resolved
Hide resolved
| @@ -192,7 +201,7 @@ String login() throws Exception { | |||
| try { | |||
| response = callback.getResponse(); | |||
| if (!response.equals("")) { | |||
| logger.info("Altona protocol violation - didn't start with an inital empty response: '{}'", response); | |||
| logger.debug("Altona protocol violation - didn't start with an inital empty response: '{}'", response); | |||
| } | |||
| } catch (Exception e) { | |||
There was a problem hiding this comment.
Please do not catch Exception. I assume IOException is enough. Catching Exception also catches NPE and hides programming errors.
There was a problem hiding this comment.
I completely agree. However in this instance, the exception being caught is explicitly thrown as Exception in getResponse() on lines 1260 & 1262. I could change those to be IOException or a custom exception. What do you think?
There was a problem hiding this comment.
I just looked at the rest of the code. This should never have been merged. Removing the Exception here will require some bigger refactoring, which is clearly out of scope here. Leave it as is.
| if (!response.equals("")) { | ||
| logger.debug("Altona protocol violation - didn't start with an inital empty response: '{}'", response); | ||
| } | ||
| } catch (Exception e) { |
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
J-N-K
approved these changes
Dec 25, 2020
| @@ -192,7 +201,7 @@ String login() throws Exception { | |||
| try { | |||
| response = callback.getResponse(); | |||
| if (!response.equals("")) { | |||
| logger.info("Altona protocol violation - didn't start with an inital empty response: '{}'", response); | |||
| logger.debug("Altona protocol violation - didn't start with an inital empty response: '{}'", response); | |||
| } | |||
| } catch (Exception e) { | |||
There was a problem hiding this comment.
I just looked at the rest of the code. This should never have been merged. Removing the Exception here will require some bigger refactoring, which is clearly out of scope here. Leave it as is.
...atlona/src/main/java/org/openhab/binding/atlona/internal/pro3/AtlonaPro3PortocolHandler.java
Show resolved
Hide resolved
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
* Add support for the AT-PRO3HD66M Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
seaside1
pushed a commit
to seaside1/openhab-addons
that referenced
this pull request
Dec 28, 2020
* Add support for the AT-PRO3HD66M Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Joseph Hagberg <joseph@zoidberg.se>
nowaterman
pushed a commit
to nowaterman/openhab-addons
that referenced
this pull request
Jan 19, 2021
* Add support for the AT-PRO3HD66M
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* Add support for the AT-PRO3HD66M Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Add support for the AT-PRO3HD66M Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the older (non-UHD) model AT-PRO3HD66M matrix. This device required a slightly different login protocol and selective bypassing of some of the status inquires. This was necessary because sending large amounts of commands to the device that it did not understand would cause it to lock up.
@tmrobert8