[rrd4j] Avoid IAE thrown if e.g. invalid start/end time given #14238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
added
the
bug
jlaur
reviewed
Jan 17, 2023
...ence.rrd4j/src/main/java/org/openhab/persistence/rrd4j/internal/RRD4jPersistenceService.java
Outdated
Show resolved
Hide resolved
jlaur
requested changes
Jan 18, 2023
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
changed the title
jlaur
reviewed
Jan 20, 2023
Comment on lines
+321
to
+327
| // do not call method {@link RrdDb#createFetchRequest(ConsolFun, long, long, long)} if start > end to avoid | ||
| // an IAE to be thrown | ||
| if (start > end) { | ||
| logger.warn("Could not query rrd4j database for item '{}': start ({}) > end ({})", itemName, start, | ||
| end); | ||
| return List.of(); | ||
| } |
There was a problem hiding this comment.
We could consider throwing IllegalArgumentException by ourselves here, since this would now be a bug on caller side, where previously it was an internal bug within this method. But let's leave something for future improvement also. 🙂
jlaur
approved these changes
Jan 20, 2023
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…b#14238) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
…b#14238) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
…b#14238) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FetchRequestcalled bycreateFetchRequestmethod (e.g. invalid start/end time given)See https://github.com/rrd4j/rrd4j/blob/85183713741c648b88926ed3085c4dd87fd9016f/src/main/java/org/rrd4j/core/FetchRequest.java
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de