Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rrd4j] Avoid IAE thrown if e.g. invalid start/end time given #14238

Merged
merged 2 commits into from
Jan 20, 2023
Merged

[rrd4j] Avoid IAE thrown if e.g. invalid start/end time given #14238

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a77887d
Catch IAE thrown if e.g. invalid start/end time given
cweitkamp Jan 17, 2023
41e5ba1
Incorporated comments from review
cweitkamp Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...e.rrd4j/src/main/java/org/openhab/persistence/rrd4j/internal/RRD4jPersistenceService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ public Iterable<HistoricItem> query(FilterCriteria filter) {
ts += step;
}
return items;
} catch (IOException e) {
} catch (IllegalArgumentException | IOException e) {
jlaur marked this conversation as resolved.
Show resolved Hide resolved
logger.warn("Could not query rrd4j database for item '{}': {}", itemName, e.getMessage());
return List.of();
} finally {
Expand Down