-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mqtt.homeassistant] Add support for Update component #14241
Conversation
aca1cd9
to
dbb665b
Compare
dbb665b
to
86e55be
Compare
Ping @antroids 🙏 |
This component is fairly non-standard - it doesn't add any channels. Instead, it provides several properties to the thing, and also adds a thing configuration allowing you to trigger an OTA update on a Home Assistant device from MainUI. Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
86e55be
to
973a7b1
Compare
Rebased (with no changes), then new commit added to fix compilation problems caused by now being on top of #15427 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these .xml configs changes merged from another PR?
...ssistant/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/Update.java
Outdated
Show resolved
Hide resolved
...ssistant/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/Update.java
Outdated
Show resolved
Hide resolved
...ssistant/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/Update.java
Outdated
Show resolved
Hide resolved
...ssistant/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/Update.java
Outdated
Show resolved
Hide resolved
...ssistant/src/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/Update.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Cody Cutrer <cody@cutrer.us>
No, they're intentionally part of this PR. The "doUpdate" parameter is part of the thing's config description. The XML changes change the config description from being inline in the thing's XML, to be a ref to a separate config description, and then duplicated to have a separate config description that adds the doUpdate parameter. Then all the thing handler has to do to "add" the doUpdate parameter is change the refed config description on the thing from the base one to the one that has the doUpdate parameters, instead of having to generate a new config description on the fly. |
.../java/org/openhab/binding/mqtt/homeassistant/internal/handler/HomeAssistantThingHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Cody Cutrer <cody@cutrer.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
I didn't test it, hope these dynamic thing configs works well on the UI
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-3-4-release-discussion/142257/235 |
Anything pending before this can be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment
...b.binding.mqtt.homeassistant/src/main/resources/OH-INF/config/homeassistant-thing-config.xml
Outdated
Show resolved
Hide resolved
@ccutrer : please consider my comment before Sunday if you would like that PR being part of OH 4.1. |
Signed-off-by: Cody Cutrer <cody@cutrer.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
* [mqtt.homeassistant] add support for Update component This component is fairly non-standard - it doesn't add any channels. Instead, it provides several properties to the thing, and also adds a thing configuration allowing you to trigger an OTA update on a Home Assistant device from MainUI. --------- Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Martin Grześlowski <martin.grzeslowski@gmail.com>
* [mqtt.homeassistant] add support for Update component This component is fairly non-standard - it doesn't add any channels. Instead, it provides several properties to the thing, and also adds a thing configuration allowing you to trigger an OTA update on a Home Assistant device from MainUI. --------- Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
* [mqtt.homeassistant] add support for Update component This component is fairly non-standard - it doesn't add any channels. Instead, it provides several properties to the thing, and also adds a thing configuration allowing you to trigger an OTA update on a Home Assistant device from MainUI. --------- Signed-off-by: Cody Cutrer <cody@cutrer.us>
This component is fairly non-standard - it doesn't add any channels. Instead, it provides several properties to the thing, and also adds a thing configuration allowing you to trigger an OTA update on a Home Assistant device from MainUI.
Fixes #14022, #14881