Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.homeassistant] Add support for Update component #14241

Merged
merged 5 commits into from
Dec 14, 2023

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Jan 17, 2023

This component is fairly non-standard - it doesn't add any channels. Instead, it provides several properties to the thing, and also adds a thing configuration allowing you to trigger an OTA update on a Home Assistant device from MainUI.

Fixes #14022, #14881

@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Jan 21, 2023
@wborn wborn changed the title [mqtt.homeassistant] add support for Update component [mqtt.homeassistant] Add support for Update component Mar 17, 2023
@ccutrer ccutrer force-pushed the mqtt-homeassistant-update branch 2 times, most recently from aca1cd9 to dbb665b Compare April 17, 2023 19:46
@ccutrer ccutrer force-pushed the mqtt-homeassistant-update branch from dbb665b to 86e55be Compare November 14, 2023 14:36
@ccutrer
Copy link
Contributor Author

ccutrer commented Nov 14, 2023

Ping @antroids 🙏

@jlaur jlaur added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Nov 18, 2023
This component is fairly non-standard - it doesn't add any channels.
Instead, it provides several properties to the thing, and also adds
a thing configuration allowing you to trigger an OTA update on a
Home Assistant device from MainUI.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer force-pushed the mqtt-homeassistant-update branch from 86e55be to 973a7b1 Compare November 18, 2023 23:28
@ccutrer
Copy link
Contributor Author

ccutrer commented Nov 18, 2023

Rebased (with no changes), then new commit added to fix compilation problems caused by now being on top of #15427

Copy link
Contributor

@antroids antroids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these .xml configs changes merged from another PR?

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer
Copy link
Contributor Author

ccutrer commented Nov 19, 2023

Are these .xml configs changes merged from another PR?

No, they're intentionally part of this PR. The "doUpdate" parameter is part of the thing's config description. The XML changes change the config description from being inline in the thing's XML, to be a ref to a separate config description, and then duplicated to have a separate config description that adds the doUpdate parameter. Then all the thing handler has to do to "add" the doUpdate parameter is change the refed config description on the thing from the base one to the one that has the doUpdate parameters, instead of having to generate a new config description on the fly.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Copy link
Contributor

@antroids antroids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
I didn't test it, hope these dynamic thing configs works well on the UI

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-3-4-release-discussion/142257/235

@ccutrer
Copy link
Contributor Author

ccutrer commented Nov 27, 2023

Anything pending before this can be merged?

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment

@lolodomo
Copy link
Contributor

@ccutrer : please consider my comment before Sunday if you would like that PR being part of OH 4.1.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 98fb791 into openhab:main Dec 14, 2023
3 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Dec 14, 2023
@ccutrer ccutrer deleted the mqtt-homeassistant-update branch December 14, 2023 22:53
magx2 pushed a commit to magx2/openhab2-addons that referenced this pull request Dec 15, 2023
* [mqtt.homeassistant] add support for Update component

This component is fairly non-standard - it doesn't add any channels.
Instead, it provides several properties to the thing, and also adds
a thing configuration allowing you to trigger an OTA update on a
Home Assistant device from MainUI.

---------

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Martin Grześlowski <martin.grzeslowski@gmail.com>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
* [mqtt.homeassistant] add support for Update component

This component is fairly non-standard - it doesn't add any channels.
Instead, it provides several properties to the thing, and also adds
a thing configuration allowing you to trigger an OTA update on a
Home Assistant device from MainUI.

---------

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
* [mqtt.homeassistant] add support for Update component

This component is fairly non-standard - it doesn't add any channels.
Instead, it provides several properties to the thing, and also adds
a thing configuration allowing you to trigger an OTA update on a
Home Assistant device from MainUI.

---------

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mqtt.homeassistant] HomeAssistant discover error openhab 3.4
5 participants