Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mqtt.homeassistant] fix compilation problems #15915

Merged
merged 1 commit into from
Nov 18, 2023

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Nov 18, 2023

Due to #15427 and #14839 being developed independently, but merged to main successively

Due to openhab#15427 and openhab#14839 being developed independently, but merged
to main successively

Signed-off-by: Cody Cutrer <cody@cutrer.us>
@ccutrer ccutrer requested a review from antroids as a code owner November 18, 2023 22:33
@ccutrer
Copy link
Contributor Author

ccutrer commented Nov 18, 2023

cc @jlaur @lolodomo

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur
Copy link
Contributor

jlaur commented Nov 18, 2023

@ccutrer - thanks for the quick fix!

@jlaur jlaur merged commit 8ca03bd into openhab:main Nov 18, 2023
2 checks passed
@jlaur jlaur added this to the 4.1 milestone Nov 18, 2023
@ccutrer ccutrer deleted the mqtt-homeassistant-compilation-error branch November 18, 2023 22:39
@lolodomo
Copy link
Contributor

@ccutrer : no need to check/update your other MQTT homeassistant PRs ?

@ccutrer
Copy link
Contributor Author

ccutrer commented Nov 18, 2023

@ccutrer : no need to check/update your other MQTT homeassistant PRs ?

#14241 needed rebased and fixed. The others were already written in such a way that they'd be fine once #15427 was merged.

andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
Due to openhab#15427 and openhab#14839 being developed independently, but merged
to main successively

Signed-off-by: Cody Cutrer <cody@cutrer.us>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Due to openhab#15427 and openhab#14839 being developed independently, but merged
to main successively

Signed-off-by: Cody Cutrer <cody@cutrer.us>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants