Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lgwebos] Add TLS support #14331

Merged
merged 1 commit into from
Feb 4, 2023
Merged

[lgwebos] Add TLS support #14331

merged 1 commit into from
Feb 4, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Feb 3, 2023

Add support for TLS which is required by latest webOS firmware.

TLS is supported also by older firmware versions, and therefore it's enabled by default. An advanced configuration parameter is provided to manually turning it off in case of compatibility problems.

JARs for testing:

Fixes #14309

Fixes openhab#14309

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Feb 3, 2023
@jlaur jlaur marked this pull request as ready for review February 3, 2023 22:25
@jlaur jlaur requested a review from sprehn as a code owner February 3, 2023 22:25
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 8a4033c into openhab:main Feb 4, 2023
@lolodomo lolodomo added this to the 4.0 milestone Feb 4, 2023
@jlaur jlaur deleted the 14309-lgwebos-tls branch February 4, 2023 12:47
@lolodomo
Copy link
Contributor

lolodomo commented Feb 4, 2023

Candidate for 3.4.x branch @jlaur

jlaur added a commit that referenced this pull request Feb 4, 2023
Fixes #14309

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Feb 4, 2023
lolodomo added a commit to lolodomo/openhab-addons that referenced this pull request Feb 11, 2023
Follow-up PR openhab#14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
jlaur pushed a commit that referenced this pull request Feb 13, 2023
Follow-up PR #14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
SMHRambo pushed a commit to SMHRambo/openhab-addons that referenced this pull request Feb 14, 2023
Follow-up PR openhab#14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Fixes openhab#14309

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Fixes openhab#14309

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Follow-up PR openhab#14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
Follow-up PR openhab#14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Fixes openhab#14309

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Follow-up PR openhab#14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LGWebOS] Firmware 03.30.16 requires use of secured web socket
2 participants