Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lgwebos] Create WEB socket client using OH core method #14382

Merged
merged 1 commit into from
Feb 13, 2023
Merged

[lgwebos] Create WEB socket client using OH core method #14382

merged 1 commit into from
Feb 13, 2023

Conversation

lolodomo
Copy link
Contributor

Follow-up PR #14331

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
[lgwebos] Create WEB socket client using OH core method
13c1737 
Follow-up PR openhab#14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added the awaiting other PR Depends on another PR label Feb 11, 2023
@lolodomo lolodomo requested a review from sprehn as a code owner February 11, 2023 11:39
@lolodomo
Copy link
Contributor Author

This PR depends on openhab/openhab-core#3356.

@lolodomo
Copy link
Contributor Author

Core PR is now merged, let's rebuild...

@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed awaiting other PR Depends on another PR rebuild Triggers Jenkins PR build labels Feb 12, 2023
jlaur
jlaur approved these changes Feb 12, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Feb 13, 2023
@lolodomo
Copy link
Contributor Author

Build is now ok.
If required, someone has to trigger the other build ( CI / Build).

@jlaur jlaur merged commit 0e246aa into openhab:main Feb 13, 2023
@jlaur jlaur added this to the 4.0 milestone Feb 13, 2023
@lolodomo lolodomo deleted the lgwebos_create_ws branch February 13, 2023 10:25
SMHRambo pushed a commit to SMHRambo/openhab-addons that referenced this pull request Feb 14, 2023
@lolodomo @SMHRambo
[lgwebos] Create WEB socket client using OH core method (openhab#14382)
e15338d 
Follow-up PR openhab#14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@lolodomo @nemerdaud
[lgwebos] Create WEB socket client using OH core method (openhab#14382)
2273bb6 
Follow-up PR openhab#14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@lolodomo @renescherer
[lgwebos] Create WEB socket client using OH core method (openhab#14382)
9dd5c59 
Follow-up PR openhab#14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@lolodomo @FordPrfkt
[lgwebos] Create WEB socket client using OH core method (openhab#14382)
1b1e9a0 
Follow-up PR openhab#14331

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@sprehn sprehn Awaiting requested review from sprehn sprehn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lolodomo @jlaur