Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add param sslContextFactory when creating a HTTP or web socket client #3356

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Add param sslContextFactory when creating a HTTP or web socket client #3356

merged 2 commits into from
Feb 12, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Feb 5, 2023

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo requested a review from a team as a code owner February 5, 2023 19:37
@lolodomo lolodomo changed the title Add param sslConextFactory when creating a HTTP or web socket client [WIP] Add param sslConextFactory when creating a HTTP or web socket client Feb 6, 2023
@lolodomo lolodomo changed the title [WIP] Add param sslConextFactory when creating a HTTP or web socket client Add param sslConextFactory when creating a HTTP or web socket client Feb 6, 2023
@andrewfg
Copy link
Contributor

andrewfg commented Feb 7, 2023

@lolodomo you need to change the PR title from 'sslConextFactory' => 'sslContextFactory'

@lolodomo
Add param sslContextFactory when creating a HTTP or web socket client
ca5c336 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo changed the title Add param sslConextFactory when creating a HTTP or web socket client Add param sslContextFactory when creating a HTTP or web socket client Feb 7, 2023
@lolodomo
Copy link
Contributor Author

lolodomo commented Feb 7, 2023

@lolodomo you need to change the PR title from 'sslConextFactory' => 'sslContextFactory'

Done, thank you.

@lolodomo
Copy link
Contributor Author

lolodomo commented Feb 8, 2023

The goal of this enhancement is to allow the bindings to be able to use these methods more often for secured connections.

J-N-K
J-N-K requested changes Feb 8, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

...ab.core.io.net/src/main/java/org/openhab/core/io/net/http/internal/WebClientFactoryImpl.java Outdated Show resolved Hide resolved
@lolodomo
Review comment: @nonnull annotation removed
002aa66 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo mentioned this pull request Feb 11, 2023
Merged
J-N-K
J-N-K approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Feb 12, 2023
@J-N-K J-N-K added this to the 4.0 milestone Feb 12, 2023
@J-N-K J-N-K merged commit f977a59 into openhab:main Feb 12, 2023
@lolodomo lolodomo deleted the WebClientFactory branch February 12, 2023 10:47
@mlobstein mlobstein mentioned this pull request Feb 18, 2023
Merged
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@lolodomo @splatch
Add param sslContextFactory when creating a HTTP or web socket client (…
76ff0f9 
…openhab#3356)

* Add param sslContextFactory when creating a HTTP or web socket client

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
GitOrigin-RevId: f977a59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lolodomo @andrewfg @J-N-K