Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gardena] Adjust thread name for WEB clients (avoid IAE) #14349

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

lolodomo
Copy link
Contributor

@lolodomo lolodomo commented Feb 5, 2023

OH core method expects a name length between 4 and 20.

Avoid a possible IllegalArgumentException.

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo force-pushed the gardena_http_threadname branch from d4d3dff to d4a416f Compare February 5, 2023 18:07
Copy link
Contributor

@andrewfg andrewfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo changed the title [gardena] Adjust thread name when thing UID can't be used [gardena] Adjust thread name when thing UID can't be used (avoid IAE) Feb 5, 2023
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Feb 5, 2023
@lolodomo
Copy link
Contributor Author

lolodomo commented Feb 7, 2023

Awaiting a new method in core framework.

@lolodomo lolodomo added the awaiting other PR Depends on another PR label Feb 7, 2023
@lolodomo
Copy link
Contributor Author

lolodomo commented Feb 7, 2023

Awaiting PR openhab/openhab-core#3359 to be merged to then update this PR

@lolodomo lolodomo added the work in progress A PR that is not yet ready to be merged label Feb 7, 2023
@lolodomo lolodomo force-pushed the gardena_http_threadname branch from d4a416f to 6b1db71 Compare February 7, 2023 20:32
@lolodomo lolodomo changed the title [gardena] Adjust thread name when thing UID can't be used (avoid IAE) [gardena] Adjust thread name for WEB clients (avoid IAE) Feb 7, 2023
OH core method expects a name length between 4 and 20.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the gardena_http_threadname branch from 6b1db71 to 206752a Compare February 19, 2023 18:34
@lolodomo lolodomo removed work in progress A PR that is not yet ready to be merged awaiting other PR Depends on another PR labels Feb 19, 2023
@wborn wborn merged commit 8c09334 into openhab:main Feb 19, 2023
@wborn wborn added this to the 4.0 milestone Feb 19, 2023
@lolodomo lolodomo deleted the gardena_http_threadname branch February 19, 2023 19:57
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants