-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gardena] Adjust thread name for WEB clients (avoid IAE) #14349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolodomo
force-pushed
the
gardena_http_threadname
branch
from
February 5, 2023 18:07
d4d3dff
to
d4a416f
Compare
andrewfg
approved these changes
Feb 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lolodomo
changed the title
[gardena] Adjust thread name when thing UID can't be used
[gardena] Adjust thread name when thing UID can't be used (avoid IAE)
Feb 5, 2023
Awaiting a new method in core framework. |
Awaiting PR openhab/openhab-core#3359 to be merged to then update this PR |
lolodomo
force-pushed
the
gardena_http_threadname
branch
from
February 7, 2023 20:32
d4a416f
to
6b1db71
Compare
lolodomo
changed the title
[gardena] Adjust thread name when thing UID can't be used (avoid IAE)
[gardena] Adjust thread name for WEB clients (avoid IAE)
Feb 7, 2023
OH core method expects a name length between 4 and 20. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
gardena_http_threadname
branch
from
February 19, 2023 18:34
6b1db71
to
206752a
Compare
lolodomo
removed
work in progress
A PR that is not yet ready to be merged
awaiting other PR
Depends on another PR
labels
Feb 19, 2023
wborn
approved these changes
Feb 19, 2023
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OH core method expects a name length between 4 and 20.
Avoid a possible IllegalArgumentException.
Signed-off-by: Laurent Garnier lg.hc@free.fr