New method to build a valid consumer name for a WEB client #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 7, 2023
|
Can someone please retrigger the build? Build was aborted after 180 minutes. |
|
Both fail for the same reason so it is more likely something is wrong with your changes. Maybe resolving itest runbundles fixes it? |
Correct. It is now fixed. |
wborn
reviewed
Feb 12, 2023
To associate a HTTP or WebSocket client to a thing. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
valid_consumer_name
branch
from
6286742 to
b234feb
Compare
|
Is it possible to have a review of this utility method? |
wborn
requested changes
Feb 18, 2023
...les/org.openhab.core.thing/src/main/java/org/openhab/core/thing/util/ThingWebClientUtil.java
Outdated
Show resolved
Hide resolved
...les/org.openhab.core.thing/src/main/java/org/openhab/core/thing/util/ThingWebClientUtil.java
Outdated
Show resolved
Hide resolved
...org.openhab.core.thing/src/test/java/org/openhab/core/thing/util/ThingWebClientUtilTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
@wborn : thank you for your review, your comments have been addressed. |
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
) Signed-off-by: Laurent Garnier <lg.hc@free.fr> GitOrigin-RevId: cd45dfe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To associate a HTTP or WebSocket client to a thing.
Signed-off-by: Laurent Garnier lg.hc@free.fr