Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugwise] Remove org.apache.common #14432

Merged
merged 2 commits into from
Mar 3, 2023
Merged

[plugwise] Remove org.apache.common #14432

merged 2 commits into from
Mar 3, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 18, 2023

  • Remove dependency on apache.commons

Untested, minor refactoring only from code perspective

@lsiepel
Remove org.apache.common
76bdbdc 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from wborn as a code owner February 18, 2023 13:17
@lsiepel lsiepel mentioned this pull request Feb 18, 2023
Open
wborn
wborn requested changes Feb 21, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look! I still had this on my todo list. 🙂

...nhab.binding.plugwise/src/main/java/org/openhab/binding/plugwise/internal/PlugwiseUtils.java Outdated Show resolved Hide resolved
@lsiepel
Fix comment + stringbuilder + add test
7c44fa5 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from wborn February 26, 2023 10:38
wborn
wborn approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wborn wborn merged commit 36201dd into openhab:main Mar 3, 2023
@wborn wborn added this to the 4.0 milestone Mar 3, 2023
@lsiepel lsiepel deleted the plugwise-apache3 branch March 3, 2023 14:48
miloit pushed a commit to miloit/openhab-addons that referenced this pull request Mar 10, 2023
@lsiepel @miloit
[plugwise] Remove org.apache.common (openhab#14432)
27e2750 
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: miloit <MichaelLoercher@web.de>
miloit pushed a commit to miloit/openhab-addons that referenced this pull request Mar 10, 2023
@lsiepel @miloit
[plugwise] Remove org.apache.common (openhab#14432)
ba87c1f 
Signed-off-by: lsiepel <leosiepel@gmail.com>
Signed-off-by: miloit <MichaelLoercher@web.de>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@lsiepel @renescherer
[plugwise] Remove org.apache.common (openhab#14432)
fd53cf0 
Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@lsiepel @FordPrfkt
[plugwise] Remove org.apache.common (openhab#14432)
b732564 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel mentioned this pull request Jul 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lsiepel @wborn