[plugwise] Prevent possible chomp bug #15339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lsiepel <leosiepel@gmail.com>
jlaur
reviewed
Jul 30, 2023
...b.binding.plugwise/src/main/java/org/openhab/binding/plugwise/internal/util/StringUtils.java
Outdated
Show resolved
Hide resolved
26 tasks
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
wborn
reviewed
Oct 17, 2023
...ab.binding.plugwise/src/main/java/org/openhab/binding/plugwise/internal/util/StringUtil.java
Outdated
Show resolved
Hide resolved
wborn
reviewed
Oct 17, 2023
...plugwise/src/main/java/org/openhab/binding/plugwise/internal/config/PlugwiseRelayConfig.java
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Nov 26, 2023
* Improve chomp * Adapt to core Stringutils * Improve minor null check Signed-off-by: Leo Siepel <leosiepel@gmail.com>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* Improve chomp * Adapt to core Stringutils * Improve minor null check Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #14432 the apache lib got removed. The chomp alternative implemented is not close enough to the apache lib. This PR fixes that alternative and prevents possible (not yet seen) bugs, also re-aranges some methods to a
StringUtilsclassI have some limited Plugwise setup, that i tested and it seems to work fine.
Test jar 4.1.0 here: https://1drv.ms/u/s!AnMcxmvEeupwjq5dAaDnjHKTJq_tZA?e=a1QSZ2