Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[knx] Improve thread safety, null-analysis #14509

Merged
merged 1 commit into from
Mar 6, 2023
Merged

[knx] Improve thread safety, null-analysis #14509

merged 1 commit into from
Mar 6, 2023

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Feb 26, 2023 •
edited
Loading

Carryover from smarthomej/addons#13 and smarthomej/addons#46, smarthomej/addons#60.

Also-by: Jan N. Klug github@klug.nrw

Refs: #14502

@holgerfriedrich holgerfriedrich added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Feb 26, 2023
@holgerfriedrich holgerfriedrich marked this pull request as draft February 26, 2023 17:32
@holgerfriedrich
Copy link
Member Author

As this is not a 1:1 pick, lets see if issues show up in the next days. Opening the PR today to link it in the task list.

@holgerfriedrich holgerfriedrich mentioned this pull request Feb 26, 2023
Closed
30 tasks
J-N-K
J-N-K reviewed Feb 26, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so easy to compare because a lot of the null fixes were already part of your previous changes. I left just one comment, but I guess that's only cosmetic.

...b.binding.knx/src/main/java/org/openhab/binding/knx/internal/handler/DeviceThingHandler.java Show resolved Hide resolved
@holgerfriedrich holgerfriedrich removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Mar 1, 2023
@holgerfriedrich holgerfriedrich marked this pull request as ready for review March 1, 2023 20:21
@holgerfriedrich
[knx] Improve thread safety, null-analysis
8d4b7c3 
Carryover from smarthomej/addons#13 and smarthomej/addons#46, smarthomej/addons#60.

Also-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich
Copy link
Member Author

@J-N-K I would like to merge this as a separate PR (#14534 is based on this one as well and does include it, but will take a bit more time to complete)

jlaur
jlaur approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 7ec7de5 into openhab:main Mar 6, 2023
@jlaur jlaur added this to the 4.0 milestone Mar 6, 2023
@holgerfriedrich holgerfriedrich deleted the pr-knx-smarthomej13 branch March 10, 2023 05:46
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@holgerfriedrich @renescherer
[knx] Improve thread safety, null-analysis (openhab#14509)
fb24861 
Carryover from smarthomej/addons#13 and smarthomej/addons#46, smarthomej/addons#60.

Also-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@holgerfriedrich @FordPrfkt
[knx] Improve thread safety, null-analysis (openhab#14509)
aa01e88 
Carryover from smarthomej/addons#13 and smarthomej/addons#46, smarthomej/addons#60.

Also-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K left review comments

@jlaur jlaur jlaur approved these changes

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@holgerfriedrich @J-N-K @jlaur