Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[knx] Backport SmartHome/J enhancements and fixes #14502

Closed
30 tasks done
holgerfriedrich opened this issue Feb 25, 2023 · 6 comments · Fixed by #15297
Closed
30 tasks done

[knx] Backport SmartHome/J enhancements and fixes #14502

holgerfriedrich opened this issue Feb 25, 2023 · 6 comments · Fixed by #15297
Assignees
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@holgerfriedrich
Copy link
Member

holgerfriedrich commented Feb 25, 2023

knx binding was forked to SmartHome/J, and in the meantime has evolved in both repositories.

This issue summarizes all improvements done in openHAB KNX Binding at SmartHome/J
and the status of backporting those enhancements as discussed in #14129.

@holgerfriedrich
Copy link
Member Author

@J-N-K commented on #14511:

I think the biggest improvement regarding code style and extensibility comes from the removal of the core type mapper and the refactoring to value(de)coders.

Yes, smarthomej/addons#208 will be fun to merge ;-) It somehow obsoletes the changes done in the meantime.... Will see how it fits together.

The second point I am concerned of is the UOM handling, especially as I have not much experience with it and see a huge potential to break existing installation.....

@J-N-K
Copy link
Member

J-N-K commented Apr 18, 2023

@holgerfriedrich Anything left to do here?

@holgerfriedrich
Copy link
Member Author

Status above still valid, did not find time to complete

@lolodomo
Copy link
Contributor

lolodomo commented May 3, 2023

@holgerfriedrich and @J-N-K : can this issue be closed now?

@holgerfriedrich
Copy link
Member Author

@lolodomo Status above is valid, new list of manufacturers not backported yet

@lolodomo
Copy link
Contributor

lolodomo commented May 4, 2023

Ok I missed one was not yet done.

@holgerfriedrich holgerfriedrich linked a pull request Jul 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants