[knx] Refactor manufacturer map #15297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes adding new manufacturers easy. Signed-off-by: Jan N. Klug <github@klug.nrw>
holgerfriedrich
requested changes
Jul 23, 2023
There was a problem hiding this comment.
Thanks, @J-N-K, for completing this.
I am missing 2 manufacturers which are not contained in the new file:
34 = eVoKNX
373 = ZF Friedrichshafen AG
|
Did you consider smarthomej/addons#371? |
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
The other code is more generic and there are more things that can go wrong. I omitted the error handling for cases that cannot occur in this version. |
holgerfriedrich
approved these changes
Jul 24, 2023
30 tasks
30 tasks
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Sep 29, 2023
* [knx] Refactor manufacturer map This makes adding new manufacturers easy. Signed-off-by: Jan N. Klug <github@klug.nrw>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
* [knx] Refactor manufacturer map This makes adding new manufacturers easy. Signed-off-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes adding new manufacturers easy and is the last improvement that was missing for the re-integration of the KNX binding.