[knx] fix fallback to DecimalType in number conversion #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
changed the title
30 tasks
holgerfriedrich
added a commit
to holgerfriedrich/openhab-addons
that referenced
this pull request
Mar 10, 2023
Carryover from smarthomej/addons#279. Also-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
added a commit
to holgerfriedrich/openhab-addons
that referenced
this pull request
Mar 12, 2023
Carryover from smarthomej/addons#279. Also-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
jlaur
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Mar 17, 2023
* [knx] Refactoring, add basic support for UOM Preparation for refactoring KnxCoreTypeMapper. Carryover from smarthomej/addons#107. Merge UOM implementations. * [knx] Adapt tests DPT strings for QuantityType now strip off a tailing .0 when decimals are converted. * [knx] Refactoring Use pattern matching with instanceof operator (new Java17 feature). * [knx] Refactoring, performance improvements Introduce KNXChannel class. Carryover from smarthomej/addons#114. * [knx] Add warning for incompatible DPT type Configuring incompatible DPT/channel combinations (e.g. DPT 1.005 (alarm) on Contact channels or DPT 1.019 (windows/door) on Switch channels) is not allowed but was silently ignored. This PR adds a warning in case incompatible configurations are detected. Carryover from smarthomej/addons#203. * [knx] Add full support for UoM Replace UoM handling with the implementation from smarthome/j. Carryover from smarthomej/addons#206. * [knx] Refactor KNXCoreTypeMapper, add RGBW and xyY Carryover from smarthomej/addons#208. * [knx] Fix RGB conversion Carryover from smarthomej/addons#219. * [knx] Remove workarounds obsoleted by Calimero 2.5 Carryover from smarthomej/addons#226. * [knx] Add parameter for disabling incoming UoM Carryover from smarthomej/addons#230. * [knx] Fix fallback to DecimalType in number conversion Carryover from smarthomej/addons#279. * [knx] Fix DPT 251.600 decoding Carryover from smarthomej/addons#349. * [knx] Fix UoM handling for special types * [knx] Add test for KNXChannelFactory * [knx] Update CODEOWNERS for knx * [knx] Default conversion for DPT 5.001 and 6.001 * [knx] Fix write blocked forever after read from bus Carryover from smarthomej/addons#299 and smarthomej/addons#330. * [knx] Use new class ColorUtil from core for HSB conversion Also-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
renescherer
pushed a commit
to renescherer/openhab-addons
that referenced
this pull request
Mar 23, 2023
* [knx] Refactoring, add basic support for UOM Preparation for refactoring KnxCoreTypeMapper. Carryover from smarthomej/addons#107. Merge UOM implementations. * [knx] Adapt tests DPT strings for QuantityType now strip off a tailing .0 when decimals are converted. * [knx] Refactoring Use pattern matching with instanceof operator (new Java17 feature). * [knx] Refactoring, performance improvements Introduce KNXChannel class. Carryover from smarthomej/addons#114. * [knx] Add warning for incompatible DPT type Configuring incompatible DPT/channel combinations (e.g. DPT 1.005 (alarm) on Contact channels or DPT 1.019 (windows/door) on Switch channels) is not allowed but was silently ignored. This PR adds a warning in case incompatible configurations are detected. Carryover from smarthomej/addons#203. * [knx] Add full support for UoM Replace UoM handling with the implementation from smarthome/j. Carryover from smarthomej/addons#206. * [knx] Refactor KNXCoreTypeMapper, add RGBW and xyY Carryover from smarthomej/addons#208. * [knx] Fix RGB conversion Carryover from smarthomej/addons#219. * [knx] Remove workarounds obsoleted by Calimero 2.5 Carryover from smarthomej/addons#226. * [knx] Add parameter for disabling incoming UoM Carryover from smarthomej/addons#230. * [knx] Fix fallback to DecimalType in number conversion Carryover from smarthomej/addons#279. * [knx] Fix DPT 251.600 decoding Carryover from smarthomej/addons#349. * [knx] Fix UoM handling for special types * [knx] Add test for KNXChannelFactory * [knx] Update CODEOWNERS for knx * [knx] Default conversion for DPT 5.001 and 6.001 * [knx] Fix write blocked forever after read from bus Carryover from smarthomej/addons#299 and smarthomej/addons#330. * [knx] Use new class ColorUtil from core for HSB conversion Also-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
FordPrfkt
pushed a commit
to FordPrfkt/openhab-addons
that referenced
this pull request
Apr 20, 2023
* [knx] Refactoring, add basic support for UOM Preparation for refactoring KnxCoreTypeMapper. Carryover from smarthomej/addons#107. Merge UOM implementations. * [knx] Adapt tests DPT strings for QuantityType now strip off a tailing .0 when decimals are converted. * [knx] Refactoring Use pattern matching with instanceof operator (new Java17 feature). * [knx] Refactoring, performance improvements Introduce KNXChannel class. Carryover from smarthomej/addons#114. * [knx] Add warning for incompatible DPT type Configuring incompatible DPT/channel combinations (e.g. DPT 1.005 (alarm) on Contact channels or DPT 1.019 (windows/door) on Switch channels) is not allowed but was silently ignored. This PR adds a warning in case incompatible configurations are detected. Carryover from smarthomej/addons#203. * [knx] Add full support for UoM Replace UoM handling with the implementation from smarthome/j. Carryover from smarthomej/addons#206. * [knx] Refactor KNXCoreTypeMapper, add RGBW and xyY Carryover from smarthomej/addons#208. * [knx] Fix RGB conversion Carryover from smarthomej/addons#219. * [knx] Remove workarounds obsoleted by Calimero 2.5 Carryover from smarthomej/addons#226. * [knx] Add parameter for disabling incoming UoM Carryover from smarthomej/addons#230. * [knx] Fix fallback to DecimalType in number conversion Carryover from smarthomej/addons#279. * [knx] Fix DPT 251.600 decoding Carryover from smarthomej/addons#349. * [knx] Fix UoM handling for special types * [knx] Add test for KNXChannelFactory * [knx] Update CODEOWNERS for knx * [knx] Default conversion for DPT 5.001 and 6.001 * [knx] Fix write blocked forever after read from bus Carryover from smarthomej/addons#299 and smarthomej/addons#330. * [knx] Use new class ColorUtil from core for HSB conversion Also-by: Jan N. Klug <github@klug.nrw> Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in #208 which results in erroneous handling of values received from the KNX bus without unit.
Signed-off-by: Jan N. Klug github@klug.nrw