Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nest] Remove WWN support #15418

Merged
merged 2 commits into from
Sep 6, 2023
Merged

[nest] Remove WWN support #15418

merged 2 commits into from
Sep 6, 2023

Conversation

wborn
Copy link
Member

@wborn wborn commented Aug 12, 2023

See: https://support.google.com/googlenest/answer/9293712?hl=en

Starting September 29, 2023, all Works with Nest connections will stop working.

Closes #13525
Closes #14761

@wborn wborn added the work in progress A PR that is not yet ready to be merged label Aug 12, 2023
@wborn wborn mentioned this pull request Aug 14, 2023
Closed
@wborn wborn force-pushed the nest-remove-wwn-support branch 2 times, most recently from 4e2a717 to 82a06ac Compare August 20, 2023 14:58
@wborn wborn force-pushed the nest-remove-wwn-support branch from 82a06ac to b1313e3 Compare August 30, 2023 19:32
@wborn wborn marked this pull request as ready for review August 30, 2023 19:32
@wborn wborn requested a review from a team as a code owner August 30, 2023 19:32
@wborn wborn removed the work in progress A PR that is not yet ready to be merged label Aug 30, 2023
jlaur
jlaur requested changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the implementation of this soon to be removed cloud service. 😢 But most of all, thanks for contributing to it in the first place. It was great while it lasted!

I have added some minor comments for the README.

bundles/org.openhab.binding.nest/README.md Outdated

The SDM API currently does not support Nest Protect devices.
There are no structure Things when using the SDM API, because the SDM API does not support setting the Home/Away status like the WWN API does.
There are no structure Things when using the SDM API, because the SDM API does not support setting the Home/Away status.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this will be a confusing note when reading this in the future - I'm wondering if the sentence should be removed entirely to keep readers from wondering what a "structure" Thing is?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it!

bundles/org.openhab.binding.nest/README.md Outdated

To use one of the Nest APIs, add the corresponding Account Thing using the UI and configure the required parameters.
To use the Nest SDM API, add an Account Thing using the UI and configure the required parameters.
After configuring an Account Thing, you can use it to discover the connected devices which are then added the Inbox.

## SDM Account Configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this could now be simplified to:

Suggested change
## SDM Account Configuration
## Account Configuration

bundles/org.openhab.binding.nest/README.md Outdated
After configuring an Account Thing, you can use it to discover the connected devices which are then added the Inbox.

## SDM Account Configuration

### Google Account Requirement

To be able to use the SDM API it is required that you use a Google Account with your Nest devices.
If you still use the WWN API, you can no longer use the WWN API after migrating to a Google Account.
So if you have not yet migrated your account, check that all the functionality you require is provided by the SDM API and SDM Things in the binding.
Most notably, there is no support for the Nest Protect in the SDM API and you cannot change your Home/Away status.
To migrate to a Google account, follow the migration steps in the [Nest accounts FAQ](https://support.google.com/googlenest/answer/9297676?co=GENIE.Platform%3DiOS&hl=en&oco=0#accountmigration&accountmigration1&#accountmigration2&#accountmigration3&zippy=%2Chow-do-i-migrate-my-account)

### SDM Configuration Parameters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above.

Suggested change
### SDM Configuration Parameters
### Configuration Parameters

bundles/org.openhab.binding.nest/README.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be worth putting some kind of historical note that WWN is no longer available?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

wborn added 2 commits September 3, 2023 09:49
@wborn
[nest] Remove WWN support
e8b4f79 
See: https://support.google.com/googlenest/answer/9293712?hl=en

> Starting September 29, 2023, all Works with Nest connections will stop working.

Closes openhab#13525
Closes openhab#14761

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Address review comments
6ae87ba 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the nest-remove-wwn-support branch from b1313e3 to 6ae87ba Compare September 3, 2023 07:57
@wborn wborn requested a review from jlaur September 6, 2023 14:45
jlaur
jlaur approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 5a80396 into openhab:main Sep 6, 2023
@jlaur jlaur added this to the 4.1 milestone Sep 6, 2023
@wborn wborn deleted the nest-remove-wwn-support branch September 6, 2023 15:04
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
@wborn @Pshatsillo
[nest] Remove WWN support (openhab#15418)
f9b257f 
See: https://support.google.com/googlenest/answer/9293712?hl=en

> Starting September 29, 2023, all Works with Nest connections will stop working.

Closes openhab#13525
Closes openhab#14761

Signed-off-by: Wouter Born <github@maindrain.net>
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
@wborn @pat-git023
[nest] Remove WWN support (openhab#15418)
7808bf2 
See: https://support.google.com/googlenest/answer/9293712?hl=en

> Starting September 29, 2023, all Works with Nest connections will stop working.

Closes openhab#13525
Closes openhab#14761

Signed-off-by: Wouter Born <github@maindrain.net>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@wborn @querdenker2k
[nest] Remove WWN support (openhab#15418)
75c7963 
See: https://support.google.com/googlenest/answer/9293712?hl=en

> Starting September 29, 2023, all Works with Nest connections will stop working.

Closes openhab#13525
Closes openhab#14761

Signed-off-by: Wouter Born <github@maindrain.net>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@wborn @querdenker2k
[nest] Remove WWN support (openhab#15418)
c417af2 
See: https://support.google.com/googlenest/answer/9293712?hl=en

> Starting September 29, 2023, all Works with Nest connections will stop working.

Closes openhab#13525
Closes openhab#14761

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@wborn @austvik
[nest] Remove WWN support (openhab#15418)
77c35b6 
See: https://support.google.com/googlenest/answer/9293712?hl=en

> Starting September 29, 2023, all Works with Nest connections will stop working.

Closes openhab#13525
Closes openhab#14761

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

[nest] Remove WWN support [nest] WWNThermostatHandlerTest unstable
2 participants
@wborn @jlaur