Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lghombot] Fix checkstyle #15603

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Sep 15, 2023

Minor checkstyle fixes.

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
@lsiepel lsiepel requested a review from a team September 15, 2023 19:40
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Comment on lines -27 to +26
* Constant field used in {@link LGHomBotDiscovery} to set the configuration property during discovery. Value of
* Constant field used in {@link org.openhab.binding.lghombot.internal.discovery.LGHomBotDiscovery} to set the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered this one many times but I did not think of this solution.
Fine.

@lolodomo lolodomo merged commit 1da4dca into openhab:main Sep 23, 2023
2 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Sep 23, 2023
@lsiepel lsiepel deleted the lghombot-checkstyle2 branch September 23, 2023 19:07
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Sep 29, 2023
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants