Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lghombot] Fix checkstyle #15603

Merged
merged 1 commit into from
Sep 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
@NonNullByDefault
public class CameraUtil {

private static final Logger logger = LoggerFactory.getLogger(CameraUtil.class);
private static final Logger LOGGER = LoggerFactory.getLogger(CameraUtil.class);

private CameraUtil() {
// No need to instance this class.
Expand Down Expand Up @@ -68,10 +68,10 @@ static State parseImageFromBytes(byte[] yuvData, int width, int height) {
ByteArrayOutputStream baos = new ByteArrayOutputStream();
try {
if (!ImageIO.write(image, "jpg", baos)) {
logger.debug("Couldn't find JPEG writer.");
LOGGER.debug("Couldn't find JPEG writer.");
}
} catch (IOException e) {
logger.info("IOException creating JPEG image.", e);
LOGGER.info("IOException creating JPEG image.", e);
}
byte[] byteArray = baos.toByteArray();
if (byteArray != null && byteArray.length > 0) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
package org.openhab.binding.lghombot.internal;

import org.eclipse.jdt.annotation.NonNullByDefault;
import org.openhab.binding.lghombot.internal.discovery.LGHomBotDiscovery;

/**
* The {@link LGHomBotConfiguration} class contains fields mapping thing configuration parameters.
Expand All @@ -24,7 +23,8 @@
public class LGHomBotConfiguration {

/**
* Constant field used in {@link LGHomBotDiscovery} to set the configuration property during discovery. Value of
* Constant field used in {@link org.openhab.binding.lghombot.internal.discovery.LGHomBotDiscovery} to set the
Comment on lines -27 to +26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered this one many times but I did not think of this solution.
Fine.

* configuration property during discovery. Value of
* this field needs to match {@link #ipAddress}
*/
public static final String IP_ADDRESS = "ipAddress";
Expand Down