Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[energidataservice] Add support for reduced electricity tax #15636

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[energidataservice] Add support for reduced electricity tax #15636

merged 1 commit into from
Oct 18, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Sep 20, 2023 •
edited
Loading

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Sep 20, 2023
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/energi-data-service-binding-4-0-0-0-4-1-0-0/144370/23

@jlaur jlaur force-pushed the 15635-energidataservice-reduced-electricity-tax branch 2 times, most recently from e184f78 to 80e926f Compare September 20, 2023 20:32
@jlaur jlaur marked this pull request as ready for review September 20, 2023 20:32
@jlaur jlaur requested a review from a team September 20, 2023 20:32
@jlaur jlaur marked this pull request as draft September 21, 2023 18:18
@jlaur
Copy link
Contributor Author

jlaur commented Sep 21, 2023 •
edited
Loading

Marking as draft as I have some doubts/ideas. Probably it would be better to expose only one channel for electricity tax and make it configurable whether to use reduced rate or not. It must be possible to change this configuration from rules, so it can be automated when the meter hits 4000 kWh, and when the date hits January 1st. This might restrict it to being configurable through a channel?

One advantage of having only a single configurable channel is that actions can use the correct electricity tax rate depending on this configuration.

@jlaur jlaur force-pushed the 15635-energidataservice-reduced-electricity-tax branch from 80e926f to f66768e Compare September 24, 2023 18:37
@jlaur jlaur mentioned this pull request Sep 25, 2023
Merged
@jlaur jlaur added the awaiting other PR Depends on another PR label Sep 30, 2023
@jlaur
Copy link
Contributor Author

jlaur commented Sep 30, 2023 •
edited
Loading

On hold, awaiting review of #15651.

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/configuration-vs-channel-modelling-question/150015/1

@jlaur jlaur removed the awaiting other PR Depends on another PR label Oct 2, 2023
@jlaur jlaur force-pushed the 15635-energidataservice-reduced-electricity-tax branch 5 times, most recently from f6d507a to d999efc Compare October 5, 2023 13:20
@jlaur jlaur changed the title [energidataservice] Add new channel for reduced electricity tax [energidataservice] Add support for reduced electricity tax Oct 5, 2023
@jlaur jlaur marked this pull request as ready for review October 6, 2023 06:08
@jlaur jlaur force-pushed the 15635-energidataservice-reduced-electricity-tax branch from d999efc to 9fa60cf Compare October 7, 2023 22:36
@jlaur
Add new channel for reduced electricity tax
3b175cc 
Resolves openhab#15635

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the 15635-energidataservice-reduced-electricity-tax branch from 9fa60cf to 3b175cc Compare October 12, 2023 07:28
lolodomo
lolodomo approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit d564eb7 into openhab:main Oct 18, 2023
2 checks passed
@lolodomo lolodomo added this to the 4.1 milestone Oct 18, 2023
@jlaur jlaur deleted the 15635-energidataservice-reduced-electricity-tax branch October 20, 2023 22:31
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
@jlaur @querdenker2k
Add new channel for reduced electricity tax (openhab#15636)
deb9102 
Resolves openhab#15635

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
@jlaur @querdenker2k
Add new channel for reduced electricity tax (openhab#15636)
5003442 
Resolves openhab#15635

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@jlaur @austvik
Add new channel for reduced electricity tax (openhab#15636)
dd714a5 
Resolves openhab#15635

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.

[energidataservice] Add channel for reduced electricity tax
3 participants
@jlaur @openhab-bot @lolodomo