[energidataservice] Refactor to eliminate code duplication #15651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
force-pushed
the
energidataservice-refactoring
branch
from
afde04b to
4f9a590
Compare
jlaur
changed the title
jlaur
force-pushed
the
energidataservice-refactoring
branch
2 times, most recently
from
6c96360 to
d691657
Compare
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
jlaur
force-pushed
the
energidataservice-refactoring
branch
from
d691657 to
4219347
Compare
This was referenced Oct 2, 2023
pat-git023
pushed a commit
to pat-git023/openhab-addons
that referenced
this pull request
Oct 13, 2023
…15651) Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 21, 2023
…15651) Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 29, 2023
…15651) Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
…15651) Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #15636, I was reminded about code duplication that increased the risk of bugs due to the potential mixing of variables, such as through copy-and-paste errors.