Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[energidataservice] Fix IllegalStateException #15693

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Oct 2, 2023

Deeper testing unfortunately revealed a regression from previous refactoring - after restarting binding:

2023-10-02 21:09:05.424 [WARN ] [mmon.WrappedScheduledExecutorService] - Scheduled runnable ended with an exception: 
java.lang.IllegalStateException: Datahub records not initialized
	at org.openhab.binding.energidataservice.internal.CacheManager.areTariffsValidTomorrow(CacheManager.java:251) ~[?:?]
	at org.openhab.binding.energidataservice.internal.handler.EnergiDataServiceHandler.downloadTariffs(EnergiDataServiceHandler.java:241) ~[?:?]
	at org.openhab.binding.energidataservice.internal.handler.EnergiDataServiceHandler.refreshElectricityPrices(EnergiDataServiceHandler.java:177) ~[?:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) ~[?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java:264) ~[?:?]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) ~[?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
	at java.lang.Thread.run(Thread.java:833) [?:?]

Regression of #15651

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Oct 2, 2023
@jlaur jlaur requested a review from a team October 2, 2023 19:48
@jlaur
Copy link
Contributor Author

jlaur commented Oct 5, 2023

@wborn - sorry for this follow-up to #15651. Do you think you can review this as well? It will fix snapshot versions as well as minimize my effort on other active development and backports for production testing. 🙂

Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@wborn wborn merged commit 75e5111 into openhab:main Oct 5, 2023
@wborn wborn added this to the 4.1 milestone Oct 5, 2023
@jlaur
Copy link
Contributor Author

jlaur commented Oct 5, 2023

@wborn - thanks!

@jlaur jlaur deleted the energidataservice-fix-dispose branch October 5, 2023 12:58
pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants