Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oppo] Update Play/Pause status to Player channel widget #15662

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

mlobstein
Copy link
Contributor

Update the state of the 'Player' channel so that the button status and its corresponding action in the UI widget will correctly reflect whether the device is in a playing or paused state.

Also some logger updates that haven been pending for a while now.

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein added the enhancement An enhancement or new feature for an existing add-on label Sep 27, 2023
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have tested this from a sitemap with a control item, and it works like a charm. Both when using physical play/pause on the player and when using the sitemap control. Previously neither worked.

@jlaur jlaur merged commit b355fa7 into openhab:main Sep 28, 2023
2 checks passed
@jlaur jlaur added this to the 4.1 milestone Sep 28, 2023
@mlobstein mlobstein deleted the oppo_control branch September 28, 2023 22:15
@mlobstein
Copy link
Contributor Author

Thanks! I have tested this from a sitemap with a control item, and it works like a charm. Both when using physical play/pause on the player and when using the sitemap control. Previously neither worked.

That is great to hear! Thanks for checking it out,

pat-git023 pushed a commit to pat-git023/openhab-addons that referenced this pull request Oct 13, 2023
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants