Update Play/Pause status to Player channel widget (openhab#15662)

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
querdenker2k · Oct 29, 2023 · 777d493 · 777d493
1 parent f24abae
commit 777d493
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/bundles/org.openhab.binding.oppo/README.md b/bundles/org.openhab.binding.oppo/README.md
@@ -168,7 +168,9 @@ String oppo_remote_button "Remote Button [%s]" { channel="oppo:player:myoppo:rem
 secondsformat.js:
 
 ```javascript
-(function(totalSeconds) {
+(function(timestamp) {
+    var totalSeconds = Date.parse(timestamp) / 1000
+
     if (isNaN(totalSeconds)) {
         return '-';
     } else {

diff --git a/...hab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/handler/OppoHandler.java b/...hab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/handler/OppoHandler.java
@@ -324,11 +324,11 @@ public void handleCommand(ChannelUID channelUID, Command command) {
                         }
                         break;
                     default:
-                        logger.warn("Unknown Command {} from channel {}", command, channel);
+                        logger.debug("Unknown command {} from channel {}", command, channel);
                         break;
                 }
             } catch (OppoException e) {
-                logger.warn("Command {} from channel {} failed: {}", command, channel, e.getMessage());
+                logger.debug("Command {} from channel {} failed: {}", command, channel, e.getMessage());
                 updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, "Sending command failed");
                 closeConnection();
                 scheduleReconnectJob();
@@ -492,6 +492,8 @@ public void onNewMessageEvent(OppoMessageEvent evt) {
                             updateChannelState(CHANNEL_SUBTITLE_TYPE, UNDEF);
                         }
                         updateChannelState(CHANNEL_PLAY_MODE, playStatus);
+                        updateState(CHANNEL_CONTROL,
+                                PLAY.equals(playStatus) ? PlayPauseType.PLAY : PlayPauseType.PAUSE);
 
                         // ejecting the disc does not produce a UDT message, so clear disc type manually
                         if (OPEN.equals(playStatus) || NO_DISC.equals(playStatus)) {
@@ -716,7 +718,7 @@ private void schedulePollingJob() {
                         }
 
                     } catch (OppoException | InterruptedException e) {
-                        logger.warn("Polling error: {}", e.getMessage());
+                        logger.debug("Polling error: {}", e.getMessage());
                     }
 
                     // if the last event received was more than 1.25 intervals ago,
@@ -835,7 +837,7 @@ private void handleControlCommand(Command command) throws OppoException {
                 connector.sendCommand(OppoCommand.REWIND);
             }
         } else {
-            logger.warn("Unknown control command: {}", command);
+            logger.debug("Unknown control command: {}", command);
         }
     }