[tesla] Remove the minimum 5A charge current limit #15711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakan42
reviewed
Oct 7, 2023
Done. PTAL |
J-N-K
requested changes
Oct 10, 2023
...ding.tesla/src/main/java/org/openhab/binding/tesla/internal/handler/TeslaVehicleHandler.java
Outdated
Show resolved
Hide resolved
While the app can't go lower than 5A, the API allows setting values down to 0A, and at least going to 2-3A can make sense if you want to put excess solar power into the car without also drawing some from the grid. Due to the overhead this causes it can be wasteful, so keep logging the warning about going below 5A. Signed-off-by: Ulrich Spörlein <uspoerlein@gmail.com>
J-N-K
approved these changes
Oct 11, 2023
pat-git023
pushed a commit
to pat-git023/openhab-addons
that referenced
this pull request
Oct 13, 2023
While the app can't go lower than 5A, the API allows setting values down to 0A, and at least going to 2-3A can make sense if you want to put excess solar power into the car without also drawing some from the grid. Due to the overhead this causes it can be wasteful, so keep logging the warning about going below 5A. Signed-off-by: Ulrich Spörlein <uspoerlein@gmail.com>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 21, 2023
While the app can't go lower than 5A, the API allows setting values down to 0A, and at least going to 2-3A can make sense if you want to put excess solar power into the car without also drawing some from the grid. Due to the overhead this causes it can be wasteful, so keep logging the warning about going below 5A. Signed-off-by: Ulrich Spörlein <uspoerlein@gmail.com>
querdenker2k
pushed a commit
to querdenker2k/openhab-addons
that referenced
this pull request
Oct 29, 2023
While the app can't go lower than 5A, the API allows setting values down to 0A, and at least going to 2-3A can make sense if you want to put excess solar power into the car without also drawing some from the grid. Due to the overhead this causes it can be wasteful, so keep logging the warning about going below 5A. Signed-off-by: Ulrich Spörlein <uspoerlein@gmail.com> Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
While the app can't go lower than 5A, the API allows setting values down to 0A, and at least going to 2-3A can make sense if you want to put excess solar power into the car without also drawing some from the grid. Due to the overhead this causes it can be wasteful, so keep logging the warning about going below 5A. Signed-off-by: Ulrich Spörlein <uspoerlein@gmail.com> Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the app can't go lower than 5A, the API allows setting values down to 0A, and at least going to 2-3A can make sense if you want to put excess solar power into the car without also drawing some from the grid.
Due to the overhead this causes it can be wasteful, so keep logging the warning about going below 5A. Leave the limiting/validation of values >32A up to the API, not this addon.