Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonyprojector] Fix decoding of mac address #16972

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[sonyprojector] Fix decoding of mac address #16972

merged 1 commit into from
Jul 1, 2024

Conversation

andrewfg
Copy link
Contributor

@andrewfg andrewfg commented Jul 1, 2024 •
edited
Loading

Decodes mac address as byte values rather than characters

Relates to the problem described in #16964

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

@andrewfg
[sonyprojector] fix mac address
2007e21 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added the bug An unexpected problem or unintended behavior of an add-on label Jul 1, 2024
@andrewfg andrewfg self-assigned this Jul 1, 2024
@andrewfg andrewfg requested a review from lolodomo as a code owner July 1, 2024 10:41
@andrewfg andrewfg mentioned this pull request Jul 1, 2024
Closed
@andrewfg andrewfg changed the title [sonyprojector] fix mac address [sonyprojector] Fix decoding of mac address Jul 1, 2024
lolodomo
lolodomo approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo lolodomo merged commit 11326e7 into openhab:main Jul 1, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.2 milestone Jul 1, 2024
@lolodomo
Copy link
Contributor

lolodomo commented Jul 1, 2024

I am asking myself if there is not the same issue in the method getModelName...

@andrewfg andrewfg mentioned this pull request Jul 1, 2024
Merged
@andrewfg
Copy link
Contributor Author

andrewfg commented Jul 1, 2024 •
edited
Loading

@lolodomo two things..

  1. I missed the edge case where a mac address byte value was <16 which causes the mac address to not contain leading zeros => I opened a new PR [sonyprojector] Fix edge case in mac address decoding #16976 to fix that edge case..

  2. I cannot check if getModelName is OK or not => Can you please handle that yourself?

@lolodomo
Copy link
Contributor

lolodomo commented Jul 1, 2024

2. I cannot check if getModelName is OK or not => Can you please handle that yourself?

No unfortunately I can't myself, that is why I asked @morph166955 to check logs.But I would be surprised that the current method is wrong.

@lolodomo lolodomo added regression Regression that happened during the development of a release. Not shown on final release notes. and removed regression Regression that happened during the development of a release. Not shown on final release notes. labels Jul 1, 2024
@morph166955
Copy link
Contributor

I can try to check it tonight.

psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Jul 12, 2024
@andrewfg @psmedley
[sonyprojector] fix mac address (openhab#16972)
a8a0cef 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg deleted the sonyprojecter-mac branch August 25, 2024 12:04
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@andrewfg @pgfeller
[sonyprojector] fix mac address (openhab#16972)
0e23d70 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@andrewfg @joni1993
[sonyprojector] fix mac address (openhab#16972)
2556392 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@andrewfg @matchews
[sonyprojector] fix mac address (openhab#16972)
e71ddc0 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees

@andrewfg andrewfg

Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewfg @lolodomo @morph166955