[sonyprojector] Fix edge case in mac address decoding #16976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrewfg
changed the title
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
lolodomo
approved these changes
Jul 1, 2024
lolodomo
added
the
regression
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Jul 12, 2024
* [sonyprojector] mac fix edge case * [sonyprojector] delete redundant toLowerCase() call Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
pgfeller
pushed a commit
to pgfeller/openhab-addons
that referenced
this pull request
Sep 29, 2024
* [sonyprojector] mac fix edge case * [sonyprojector] delete redundant toLowerCase() call Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993
pushed a commit
to joni1993/openhab-addons
that referenced
this pull request
Oct 15, 2024
* [sonyprojector] mac fix edge case * [sonyprojector] delete redundant toLowerCase() call Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
matchews
pushed a commit
to matchews/openhab-addons
that referenced
this pull request
Oct 18, 2024
* [sonyprojector] mac fix edge case * [sonyprojector] delete redundant toLowerCase() call Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #16972 we fixed the decoding of mac addresses, but in the edge case that the mac byte value is less than 16, the fix fails because Integer.toHexString() does not produce leading zeros (i.e. the mac address appears wrongly as
12-34-5-67-89-0instead of12-34-05-67-89-00)Signed-off-by: Andrew Fiddian-Green software@whitebear.ch