[shelly] Fix thing re-init after power cycle for firmware update #17163

markus7017 · 2024-07-27T15:31:57Z

After a power cycle all connected devices should be re-initialized and thing should go ONLINE. This was broken.
Same after a firmware upgrade. Thing went to FIRMWARE_UPDATING, but never got back ONLINE.

Closing
#17014

...hab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiRpc.java

markus7017 · 2024-07-28T11:22:19Z

@lsiepel changes applied

please also consider as back-Ort to 4.2

jlaur

Thanks for the fix. I have added a few comments as well. (FYI @lsiepel)

...nhab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/ShellyBluApi.java

...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java

...hab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiRpc.java

markus7017 · 2024-07-28T17:24:36Z

review changes are applied, please check

jlaur

Thanks for addressing comments. I have added two additional findings.

@lsiepel - anything more to add, I see your two comments are already resolved?

@markus7017, please remove the label "additional testing preferred" when verified and ready to be merged.

...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java

bundles/org.openhab.binding.shelly/README.md

markus7017 · 2024-07-29T17:19:33Z

@jlaur changes pushed

bundles/org.openhab.binding.shelly/README.md

jlaur

LGTM

lsiepel

LGTM. Was on the road last couple of days so just had a quick look. See that other comments are made and i have nothing to add.

Edit: Will merge (and backport) once tests confirmed.

jlaur · 2024-07-31T16:21:19Z

Ping @markus7017

markus7017 · 2024-07-31T20:38:25Z

I'm running the build since several days with my 60 Shellys, looks good. I'll ask for additional testing, just to make sure

jlaur · 2024-07-31T20:46:33Z

I'll ask for additional testing, just to make sure

For the avoidance of doubt, do you mean that you are going to ask user(s) to test this, then get back to this PR with confirmation when it has been succesfully tested and is ready to be merged?

Just to reiterate:

Please remove the label "additional testing preferred" when verified and ready to be merged.

on ota_success message. Signed-off-by: Markus Michels <markus7017@gmail.com>

Signed-off-by: Markus Michels <markus7017@gmail.com>

further events throughout the upgrade process Signed-off-by: Markus Michels <markus7017@gmail.com>

Signed-off-by: Markus Michels <markus7017@gmail.com>

openhab-bot · 2024-07-31T21:19:07Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/shelly-binding/56862/4003

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

markus7017 · 2024-08-02T18:05:29Z

@jlaur we are good to go

lsiepel · 2024-08-02T19:04:28Z

@jlaur we are good to go

As i’m on holiday, not able to backport now. With the upcoming point release don’t wait for me.

) * Fixes thing re-init during/after firmware update. API will not be closed on ota_success message. * Don't disconnect from device during firmware update, this ensures to get further events throughout the upgrade process * suspress COMMUNICATION_ERROR on expected restart after fw upgrade Signed-off-by: Markus Michels <markus7017@gmail.com>

…nhab#17163) * Fixes thing re-init during/after firmware update. API will not be closed on ota_success message. * Don't disconnect from device during firmware update, this ensures to get further events throughout the upgrade process * suspress COMMUNICATION_ERROR on expected restart after fw upgrade Signed-off-by: Markus Michels <markus7017@gmail.com>

…nhab#17163) * Fixes thing re-init during/after firmware update. API will not be closed on ota_success message. * Don't disconnect from device during firmware update, this ensures to get further events throughout the upgrade process * suspress COMMUNICATION_ERROR on expected restart after fw upgrade Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>

…nhab#17163) * Fixes thing re-init during/after firmware update. API will not be closed on ota_success message. * Don't disconnect from device during firmware update, this ensures to get further events throughout the upgrade process * suspress COMMUNICATION_ERROR on expected restart after fw upgrade Signed-off-by: Markus Michels <markus7017@gmail.com>

…nhab#17163) * Fixes thing re-init during/after firmware update. API will not be closed on ota_success message. * Don't disconnect from device during firmware update, this ensures to get further events throughout the upgrade process * suspress COMMUNICATION_ERROR on expected restart after fw upgrade Signed-off-by: Markus Michels <markus7017@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>

markus7017 added bug An unexpected problem or unintended behavior of an add-on work in progress A PR that is not yet ready to be merged labels Jul 27, 2024

markus7017 self-assigned this Jul 27, 2024

markus7017 linked an issue Jul 27, 2024 that may be closed by this pull request

[Shelly] Thing /device offline after a power failure #17014

Closed

markus7017 changed the title ~~[shelly][WIP] Fix thing re-init after power cycle for firmware update~~ [shelly] Fix thing re-init after power cycle for firmware update Jul 27, 2024

markus7017 removed the work in progress A PR that is not yet ready to be merged label Jul 27, 2024

markus7017 requested a review from jlaur July 27, 2024 16:42

markus7017 mentioned this pull request Jul 27, 2024

[shelly] Add support for various Gen3 devices (Plus 1/1PM, Mini 1/PM/1PM, Dimmer 0110, i4) #17166

Merged

lsiepel reviewed Jul 27, 2024

View reviewed changes

...hab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiRpc.java Outdated Show resolved Hide resolved

lsiepel reviewed Jul 27, 2024

View reviewed changes

...hab.binding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiRpc.java Show resolved Hide resolved

jlaur reviewed Jul 28, 2024

View reviewed changes

markus7017 added the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Jul 28, 2024

jlaur reviewed Jul 28, 2024

View reviewed changes

...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/handler/ShellyBaseHandler.java Outdated Show resolved Hide resolved

bundles/org.openhab.binding.shelly/README.md Outdated Show resolved Hide resolved

jlaur mentioned this pull request Jul 29, 2024

[shelly] Fix compiler warnings #17179

Merged

jlaur reviewed Jul 29, 2024

View reviewed changes

bundles/org.openhab.binding.shelly/README.md Outdated Show resolved Hide resolved

jlaur reviewed Jul 29, 2024

View reviewed changes

bundles/org.openhab.binding.shelly/README.md Show resolved Hide resolved

jlaur approved these changes Jul 29, 2024

View reviewed changes

lsiepel approved these changes Jul 29, 2024

View reviewed changes

markus7017 added 6 commits July 31, 2024 22:49

Fixes thing re-init during/after firmware update. API will not be closed

27ea779

on ota_success message. Signed-off-by: Markus Michels <markus7017@gmail.com>

fw version check restored

5b9a628

Signed-off-by: Markus Michels <markus7017@gmail.com>

Don't disconnect from device during firmware update, this ensures to get

c93a611

further events throughout the upgrade process Signed-off-by: Markus Michels <markus7017@gmail.com>

suspress COMMUNICATION_ERROR on expected restart after fw upgrade

e54a008

Signed-off-by: Markus Michels <markus7017@gmail.com>

clean-up

4ffecec

Signed-off-by: Markus Michels <markus7017@gmail.com>

apply review changes

4378e60

Signed-off-by: Markus Michels <markus7017@gmail.com>

markus7017 added 2 commits July 31, 2024 22:49

review changes applied

2c20e6a

Signed-off-by: Markus Michels <markus7017@gmail.com>

review changes applied

b01fede

Signed-off-by: Markus Michels <markus7017@gmail.com>

markus7017 force-pushed the shelly_confix branch from 184ebd6 to b01fede Compare July 31, 2024 20:50

jlaur added 2 commits August 1, 2024 12:43

thing -> Thing

6c6d4fc

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

Remove excess line

5e91b2d

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

markus7017 added community approved and removed additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Aug 1, 2024

jlaur merged commit 8c29b59 into openhab:main Aug 2, 2024
5 checks passed

jlaur added this to the 4.3 milestone Aug 2, 2024

jlaur added the patch A PR that has been cherry-picked to a patch release branch label Aug 2, 2024

markus7017 mentioned this pull request Aug 4, 2024

[shelly] Info events are sent to the alarm channel #16735

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[shelly] Fix thing re-init after power cycle for firmware update #17163

[shelly] Fix thing re-init after power cycle for firmware update #17163

markus7017 commented Jul 27, 2024 •

edited

Loading

markus7017 commented Jul 28, 2024

jlaur left a comment

markus7017 commented Jul 28, 2024

jlaur left a comment

markus7017 commented Jul 29, 2024

jlaur left a comment

lsiepel left a comment •

edited

Loading

jlaur commented Jul 31, 2024

markus7017 commented Jul 31, 2024

jlaur commented Jul 31, 2024

openhab-bot commented Jul 31, 2024

markus7017 commented Aug 2, 2024

lsiepel commented Aug 2, 2024

[shelly] Fix thing re-init after power cycle for firmware update #17163

[shelly] Fix thing re-init after power cycle for firmware update #17163

Conversation

markus7017 commented Jul 27, 2024 • edited Loading

markus7017 commented Jul 28, 2024

jlaur left a comment

Choose a reason for hiding this comment

markus7017 commented Jul 28, 2024

jlaur left a comment

Choose a reason for hiding this comment

markus7017 commented Jul 29, 2024

jlaur left a comment

Choose a reason for hiding this comment

lsiepel left a comment • edited Loading

Choose a reason for hiding this comment

jlaur commented Jul 31, 2024

markus7017 commented Jul 31, 2024

jlaur commented Jul 31, 2024

openhab-bot commented Jul 31, 2024

markus7017 commented Aug 2, 2024

lsiepel commented Aug 2, 2024

markus7017 commented Jul 27, 2024 •

edited

Loading

lsiepel left a comment •

edited

Loading