Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[freeboxos] Fix media playing #17244

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

lolodomo
Copy link
Contributor

Fix #17243

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Aug 13, 2024
@lolodomo lolodomo requested a review from clinique as a code owner August 13, 2024 12:18
@lolodomo lolodomo marked this pull request as draft August 13, 2024 12:18
Fix openhab#17243

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo force-pushed the freeboxos_play_media branch from 9bff92b to 8f97dc9 Compare August 13, 2024 13:38
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo changed the title [freeboxos] [WIP] Fix media playing [freeboxos] Fix media playing Aug 13, 2024
@lolodomo lolodomo marked this pull request as ready for review August 13, 2024 17:06
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@jlaur jlaur merged commit 0e4ce59 into openhab:main Aug 13, 2024
5 checks passed
@jlaur jlaur added this to the 4.3 milestone Aug 13, 2024
@lolodomo lolodomo deleted the freeboxos_play_media branch August 13, 2024 18:24
lolodomo added a commit to lolodomo/openhab-addons that referenced this pull request Aug 18, 2024
Partial revert of openhab#17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
jlaur pushed a commit that referenced this pull request Aug 18, 2024
Partial revert of #17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
Fix openhab#17243

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
…b#17282)

Partial revert of openhab#17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
Fix openhab#17243

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
…b#17282)

Partial revert of openhab#17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Fix openhab#17243

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
…b#17282)

Partial revert of openhab#17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Fix openhab#17243

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
…b#17282)

Partial revert of openhab#17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Nov 20, 2024
Fix openhab#17243

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Christian Koch <christian@koch-bensheim.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[freeboxos] Playing audio media though the audio sink fails
3 participants