Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[freeboxos] Keep enum in API response record DTO (play media) #17282

Merged
merged 1 commit into from
Aug 18, 2024
Merged

[freeboxos] Keep enum in API response record DTO (play media) #17282

merged 1 commit into from
Aug 18, 2024

Conversation

lolodomo
Copy link
Contributor

Partial revert of #17244

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
[freeboxos] Keep enum in API response record DTO (play media)
7f3c067 
Partial revert of openhab#17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo requested a review from clinique as a code owner August 18, 2024 10:21
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. and removed bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes. labels Aug 18, 2024
jlaur
jlaur approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@jlaur jlaur merged commit 687337f into openhab:main Aug 18, 2024
5 checks passed
@jlaur jlaur added this to the 4.3 milestone Aug 18, 2024
@jlaur jlaur added the regression Regression that happened during the development of a release. Not shown on final release notes. label Aug 18, 2024
@lolodomo lolodomo deleted the freeboxos_playmedia_enums branch August 18, 2024 11:31
digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
@lolodomo @digitaldan
[freeboxos] Keep enum in API response record DTO (play media) (openha…
28e3040 
…b#17282)

Partial revert of openhab#17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@lolodomo @pgfeller
[freeboxos] Keep enum in API response record DTO (play media) (openha…
55b6928 
…b#17282)

Partial revert of openhab#17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Patrik Gfeller <patrik.gfeller@proton.me>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@lolodomo @joni1993
[freeboxos] Keep enum in API response record DTO (play media) (openha…
dd2318f 
…b#17282)

Partial revert of openhab#17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@lolodomo @matchews
[freeboxos] Keep enum in API response record DTO (play media) (openha…
07a3e39 
…b#17282)

Partial revert of openhab#17244

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@clinique clinique clinique approved these changes

Assignees
No one assigned
Labels
regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@lolodomo @clinique @jlaur