Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enocean] Move CHANNEL_DIMMER from D2_01_08 to D2_01_09 #17429

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

lovery
Copy link
Contributor

@lovery lovery commented Sep 17, 2024

Remove CHANNEL_DIMMER from D2_01_08 (according to the documentation it is not supported by the device)
Add CHANNEL_DIMMER to D2_01_09 (according to the documentation it is supported by the device)

Additional info page 132

Fix #15079

Jar file for testing

Remove CHANNEL_DIMMER from D2_01_08 and add CHANNEL_DIMMER to D2_01_09
Fix openhab#15079

Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
@lovery lovery requested a review from fruggy83 as a code owner September 17, 2024 09:13
@lsiepel lsiepel added the bug An unexpected problem or unintended behavior of an add-on label Sep 17, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @fruggy83 please confirm

@lsiepel lsiepel changed the title [enocean] Remove and add channels [enocean] Move CHANNEL_DIMMER from D2_01_08 to D2_01_09 Sep 17, 2024
@lsiepel lsiepel merged commit e655ddb into openhab:main Oct 5, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Oct 5, 2024
@lovery lovery deleted the enocean-D2_01-08-09-fix branch October 5, 2024 15:27
@dilyanpalauzov
Copy link
Contributor

I upgraded to 4.3.0.M2, which includes this change.

For a D2_01_08 device I have the configuration below. As you can see it contains nowhere dimmer element.

The Main UI under Settings → Things → (the Enocean thing) → Thing type shows “Electronic switches and dimmers with energy measurement and local control (EEP: D2-01)”.

Why does it spell dimmer, if the item contains no dimmer?

Likewise behind “EEP for Receiving Commands” the text is “Switching, dimming and energy measurement (EEP: D2_01_08)” (For _09 the text is the same).

The same happens for “EEP for Sending Commands”. Why does it spell dimmer?

In any case, under channels after the upgrade there is no Dimmer, in 4.2.2 there is Dimmer channel.

UID: enocean:measurementSwitch:ABCDEFGH:01234567
label: E2
thingTypeUID: enocean:measurementSwitch
configuration:
  enoceanId: 01234567
  senderIdOffset: 2
  pollingInterval: 60
  suppressRepeating: false
  sendingEEPId: D2_01_08
  broadcastMessages: false
  receivingEEPId:
    - D2_01_08
bridgeUID: enocean:bridge:ABCDEFGH
channels:
  - id: lastReceived
    channelTypeUID: enocean:lastReceived
    label: ""
    configuration: {}
  - id: generalSwitch
    channelTypeUID: enocean:generalSwitch
    label: ""
    configuration: {}
  - id: repeatCount
    channelTypeUID: enocean:repeatCount
    label: ""
    configuration: {}
  - id: rssi
    channelTypeUID: enocean:rssi
    label: ""
    configuration: {}
  - id: totalusage
    channelTypeUID: enocean:totalusage
    label: ""
    configuration: {}
  - id: instantpower
    channelTypeUID: enocean:instantpower
    label: ""
    configuration: {}

@lsiepel
Copy link
Contributor

lsiepel commented Oct 7, 2024

Please create a new issue and tag this PR

@lovery
Copy link
Contributor Author

lovery commented Oct 8, 2024

@dilyanpalauzov on page 132 you can see the table Screenshot from 2024-10-08 10-19-16 not all EEP are marked with x for Dimming option (only D2_01_02, D2_01_03, D2_01_04, D2_01_05, D2_01_09) and only a few of them are marked to support Dimming configurable (D2_01_04, D2_01_05, D2_01_09), so D2_01_08 doesn't have the Dimmer option, which means that if a device is using the D2_01_08 doesn't support dimming - even if you have the dimming channel and set some values to it the device wont change it's behavior.

Thank you for pointing out the label for D2_01_08 is incorrect, I forgot to change it.

joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
Remove CHANNEL_DIMMER from D2_01_08 and add CHANNEL_DIMMER to D2_01_09
Fix openhab#15079

Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
Remove CHANNEL_DIMMER from D2_01_08 and add CHANNEL_DIMMER to D2_01_09
Fix openhab#15079

Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Jan 2, 2025
Remove CHANNEL_DIMMER from D2_01_08 and add CHANNEL_DIMMER to D2_01_09
Fix openhab#15079

Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enocean] D2-01-08 has no dimmer
3 participants