-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enocean] Move CHANNEL_DIMMER from D2_01_08 to D2_01_09 #17429
Conversation
Remove CHANNEL_DIMMER from D2_01_08 and add CHANNEL_DIMMER to D2_01_09 Fix openhab#15079 Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @fruggy83 please confirm
I upgraded to 4.3.0.M2, which includes this change. For a D2_01_08 device I have the configuration below. As you can see it contains nowhere dimmer element. The Main UI under Settings → Things → (the Enocean thing) → Thing type shows “Electronic switches and dimmers with energy measurement and local control (EEP: D2-01)”. Why does it spell dimmer, if the item contains no dimmer? Likewise behind “EEP for Receiving Commands” the text is “Switching, dimming and energy measurement (EEP: D2_01_08)” (For _09 the text is the same). The same happens for “EEP for Sending Commands”. Why does it spell dimmer? In any case, under channels after the upgrade there is no Dimmer, in 4.2.2 there is Dimmer channel. UID: enocean:measurementSwitch:ABCDEFGH:01234567
label: E2
thingTypeUID: enocean:measurementSwitch
configuration:
enoceanId: 01234567
senderIdOffset: 2
pollingInterval: 60
suppressRepeating: false
sendingEEPId: D2_01_08
broadcastMessages: false
receivingEEPId:
- D2_01_08
bridgeUID: enocean:bridge:ABCDEFGH
channels:
- id: lastReceived
channelTypeUID: enocean:lastReceived
label: ""
configuration: {}
- id: generalSwitch
channelTypeUID: enocean:generalSwitch
label: ""
configuration: {}
- id: repeatCount
channelTypeUID: enocean:repeatCount
label: ""
configuration: {}
- id: rssi
channelTypeUID: enocean:rssi
label: ""
configuration: {}
- id: totalusage
channelTypeUID: enocean:totalusage
label: ""
configuration: {}
- id: instantpower
channelTypeUID: enocean:instantpower
label: ""
configuration: {} |
Please create a new issue and tag this PR |
@dilyanpalauzov on page 132 you can see the table Thank you for pointing out the label for D2_01_08 is incorrect, I forgot to change it. |
Remove CHANNEL_DIMMER from D2_01_08 and add CHANNEL_DIMMER to D2_01_09 Fix openhab#15079 Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
Remove CHANNEL_DIMMER from D2_01_08 and add CHANNEL_DIMMER to D2_01_09 Fix openhab#15079 Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
Remove CHANNEL_DIMMER from D2_01_08 and add CHANNEL_DIMMER to D2_01_09 Fix openhab#15079 Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Remove CHANNEL_DIMMER from D2_01_08 (according to the documentation it is not supported by the device)
Add CHANNEL_DIMMER to D2_01_09 (according to the documentation it is supported by the device)
Additional info page 132
Fix #15079
Jar file for testing