-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enocean] Improve capability listing to align with EEP documentation #17522
[enocean] Improve capability listing to align with EEP documentation #17522
Conversation
receivingEEPId and sendingEEPId are kept identical. I do not know if this is correct. |
bundles/org.openhab.binding.enocean/src/main/resources/OH-INF/i18n/enocean.properties
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.enocean/src/main/resources/OH-INF/i18n/enocean.properties
Outdated
Show resolved
Hide resolved
51dd143
to
810c069
Compare
Can you also sign your commit - this will fix the DCO check? Do you know if By the way the |
I am not going to sign my commits.
No, I do not know, neither for Configurable Dimming, but it does not matter here. This changeset updates the device descriptions, so users can select based on what they have bought. I could however update README to state that the receivingEEPId and sendingEEPId descriptions include Configurable dimming and Power failure detection properties, which are supported by the device, but not implemented in OH. I have no D2_01_0C device. Do you know if receivingEEPId and sendingEEPId should be identical or distinct? |
I mean their descriptions, as changed here. |
@dilyanpalauzov I think they are identical everywhere. |
810c069
to
81bad74
Compare
81bad74
to
a0e558d
Compare
… detection configurable dimming or pilot wire, do not have local control.
a0e558d
to
b22185f
Compare
Besides the last comment that's waiting for @lovery comment, i wonder if we can merge this or if it needs to wait before the pilot wire PR is merged. As this update states pilot wire capability's |
This improves the descriptions of the devices, which otherwise had very identical spelling, and were hard to distinguish. Whether the listed features are supported by OpenHAB is secondary. |
@lsiepel - it is only label change, it won't break any functionality and I am not feeling really competent to say how it should be because I don't know if the description in the label connected to EEP in the OH interface should be according to the EnOcean specification or based on the implemented features by the OH. For example: @dilyanpalauzov there is no need to update the README.txt because there are only details about the supported functionalities, no need to add info about something that is not supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
Let's hope we can merge the pilot wire mode PR aslo before 4.3.0
… detection (openhab#17522) configurable dimming or pilot wire, do not have local control. Co-authored-by: Cody Cutrer <cody@cutrer.us>
… detection (openhab#17522) configurable dimming or pilot wire, do not have local control. Co-authored-by: Cody Cutrer <cody@cutrer.us>
This updates the descriptions for EnOcean devices, based on the table on page 132 of https://www.enocean-alliance.org/wp-content/uploads/2017/05/EnOcean_Equipment_Profiles_EEP_v2.6.7_public.pdf, whether the properties from the subject are present.
This makes the device types more distinguishable from each other, and eases the users.
In particular it replaces “dimming” with “configurable dimming” where appropriate.
I have not checked if the class implementation does support these properties (match the table): in case of D2_01_0A I have removed “energy measurement” from the description.
Related to #17429 and #17450.