[kodi] Changed 'systemcommand' channel to command options #7369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweitkamp
added
enhancement
|
@cweitkamp What are your plans for this pull request? The code looks ok. Except for the current conflict does it need any changes? |
|
@Hilbrand in general this implementation is final. I will try to solve the conflicts asap to get this PR into mergable status. |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-kodi-command-options
branch
from
2974c62
to
b9b4f84
Compare
|
@Hilbrand Rebase done. |
Hilbrand
approved these changes
Sep 13, 2020
cweitkamp
changed the title
|
Yes, of course. I removed it. |
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Oct 8, 2020
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing for openhab/openhab-core#1422 and openhab/openhab-webui#217
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de