[ui] Switch widget as default widget for Number or String items with command options #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cweitkamp
added
enhancement
|
Together with openhab/openhab-webui#217 the rendering looks like this:
|
|
I think that the default should remain a selection. The buttons are not adapted when you have 50 options ! |
|
I considered checking number of command options against |
|
Yes, that would be ok IMHO to consider a max number of options to choose between switch or selection. 4 looks ok to me as a reasonable value. |
…nd options Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-1016-command-options
branch
from
e510b5f
to
f72408e
Compare
|
I added the check for maximum number of options. |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-1016-command-options
branch
from
3274e31
to
2172d63
Compare
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
4 tasks
cweitkamp
added
rebuild
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 11, 2023
…command options (openhab#1422) Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> GitOrigin-RevId: f52af0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1016
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de