[modbus][sunspec] Removed colons in Headline #7423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
kaikreuzer
approved these changes
Apr 19, 2020
|
@kaikreuzer could it be related to the feature? For mqtt and bluetooth (where we have subbundles, too) we have an aggregated feature which installs all bundles at once. IIRC the feature is used for something during the build, right? We decided against this aggregated feature here, but this could be changed (IMO the aggregated Features should be removed, I don‘t see why I have to install the homeassistant bundle if I don‘t use it, but want to use the generic MQTT channels). |
The features define the installable units - we have one feature per add-on. |
|
I can bring the feature in-line with the other ones tomorrow. But I still think this should be discussed for OH3. Especially for Bluetooth, where there are a lot of different bundles which probably will not be used all at the same time, the „always install everything“ strategy feels wrong. |
yfre
pushed a commit
to yfre/openhab-addons
that referenced
this pull request
Apr 27, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Signed-off-by: Eugen Freiter <freiter@gmx.de>
cpmeister
changed the title
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
May 29, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
LoungeFlyZ
pushed a commit
to LoungeFlyZ/openhab2-addons
that referenced
this pull request
Jun 8, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
J-N-K
pushed a commit
to J-N-K/openhab-addons
that referenced
this pull request
Jul 14, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way. Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those seem to make the website build fail, since the yaml frontmatter is parsed wrong this way.
cc: @kaikreuzer