[modbus] Cleaned modbus binding + extension docs #7424
Conversation
Signed-off-by: Kai Kreuzer <kai@openhab.org>
kaikreuzer
changed the title
| <feature>openhab-runtime-base</feature> | ||
| <feature>openhab-binding-modbus</feature> | ||
| <feature>openhab-transport-modbus</feature> | ||
| <bundle start-level="80">mvn:org.openhab.addons.bundles/org.openhab.binding.modbus/${project.version}</bundle> |
There was a problem hiding this comment.
This is different from what we do in Bluetooth and mqtt. There we have no feature.xml at all for the bundles but add the aggregated feature in the feature-build-bundle (IIRC footer.xml).
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
features/openhab-addons/src/main/resources/footer.xml
This are the features that are installed, so we should add modbus here, too. The single-features are excluded here:
There was a problem hiding this comment.
Ok, I will add modbus there as well.
But what I don't understand yet: How/where are the aggregated features generated?
There was a problem hiding this comment.
It slowly all comes back :-). If you tell me where to put it, I‘ll add a section on feature-definition and aggregation to the developer documentation. Since this is a bit special, I‘m not sure if it should be part of the general description for binding development.
There was a problem hiding this comment.
Ok, I will add modbus there as well.
Done.
If you tell me where to put it
Hm, tricky question. We don't have anything about the general structure for an add-on yet.
https://www.openhab.org/docs/developer/buildsystem.html comes closest - maybe some info on feature definition could be added to that page, wdyt?
There was a problem hiding this comment.
Added. I already wrote an explanation for the new embedding-strategy for dependencies but forgot to create a PR for that. Shame on me.
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <features name="org.openhab.binding.modbus-${project.version}" xmlns="http://karaf.apache.org/xmlns/features/v1.4.0"> | |||
| <repository>file:${basedirRoot}/bundles/org.openhab.io.transport.modbus/target/feature/feature.xml</repository> | |||
| <repository>mvn:org.openhab.core.features.karaf/org.openhab.core.features.karaf.openhab-core/${ohc.version}/xml/features</repository> | |||
There was a problem hiding this comment.
IIRC this is not working, because the transport bundle is not available (it‘s part of addons). Therefore the feature verification will fail.
There was a problem hiding this comment.
Do we have any documentation on what how to set repository element? This is a bit confusing to me...
There was a problem hiding this comment.
Agreed. In 99+% of the bundles what you did is correct. The problem arises from the fact that the bundle depends on a feature that is not part of core but of addons. The question is, if we should integrate the transport bundle in the aggregated feature, too. Then we could add all transport bundles (including dependencies) in this feature.
There was a problem hiding this comment.
Ok, thanks, I have reverted the repo entry.
There was a problem hiding this comment.
The problem arises from the fact that the bundle depends on a feature that is not part of core but of addons
I was just browsing the addons repo when contemplating about openhab/openhab-core#1319 (comment) - and I came to the conclusion that the io.transport.modbus bundle simply does not belong in this repo, but should be moved to openhab-core, where all other io.transport bundles reside.
We can't move it for 2.5, but I'd strongly suggest that we move it for 3.0.
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
The Travis error does not look related to this PR... |
|
@J-N-K Can this be merged then? |
|
The footer.xml-adjustment is missing. Without that, it will not be possible to install modbus at all. I have left the special situation |
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
Ok, does it look better now? |
|
Just waiting for at least one CI build to succeed. |
|
Travis fails unrelated. Let‘s merge. |
* Cleaned modbus binding + extension Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Eugen Freiter <freiter@gmx.de>
* Cleaned modbus binding + extension Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Cleaned modbus binding + extension Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Cleaned modbus binding + extension Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: CSchlipp <christian@schlipp.de>
* Cleaned modbus binding + extension Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Cleaned modbus binding + extension Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Cleaned modbus binding + extension Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Cleaned modbus binding + extension Signed-off-by: Kai Kreuzer <kai@openhab.org>
* Cleaned modbus binding + extension Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
* Cleaned modbus binding + extension Signed-off-by: Kai Kreuzer <kai@openhab.org>
Signed-off-by: Kai Kreuzer kai@openhab.org