-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove parameter sendFrequency
#4338
Comments
Not in use in iOS app either. |
In Basic UI, the parameter is read but then unused for the colorpicker widget. I will submit a Basic UI PR to remove few useless lines for colorpicker => edit: done |
Note that %frequency% does not exist in colorpicker snippet. Related to openhab/openhab-core#4338 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
#2699) Note that %frequency% does not exist in colorpicker snippet. Related to openhab/openhab-core#4338 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Basic UI is now ok. |
See openhab/openhab-core#4338 (comment) Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
No, a little more. I will prepare a PR during the week. |
Related to openhab#4338 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
This feature can now be closed. |
Is your feature request related to a problem? Please describe.
This parameter has been used in Classic UI which isn't available anymore. I also checked the Android app and it isn't used there.
It may wonder people what the parameter does when they read about it in the docs.
Also see #3430 (comment)
Describe the solution you'd like
I think we should remove it at all.
Additional context
Coordination between maintainers
Notify maintainers of other UIs:
@openhab/webui-maintainers
@openhab/android-maintainers
@openhab/ios-maintainers
Checklist for implementation:
sendFrequency
openhab-docs#2346The text was updated successfully, but these errors were encountered: