[sitemap] Remove sendFrequency parameter for Slider/Colorpicker widgets

[lolodomo]

Related to #4338

Signed-off-by: Laurent Garnier lg.hc@free.fr

[mherwege]

LGTM

[kaikreuzer]

If people have this parameter in their sitemap, this is a backward-compatibility breaking change.
I wonder if we should maybe continue to allow it and rather log a warning, if people still use it. At a later stage, we could then remove it from the syntax. Wdyt?

[lolodomo]

It has been already removed from the Main UI sitemap editor.
It is very improbable that this parameter is still used by anyone or maybe only by those that have very old sitemaps dating of the age of Classic UI.
Replacing by a log is possible but will require additional work & test, I am not sure it's worth the effort.

[holgerfriedrich]

@lolodomo what will happen to users of the text based configuration?
We still list sendFrequency as an allowed option in the documentation of 4.2.x.
Or do I get something wrong?

[lolodomo]

@lolodomo what will happen to users of the text based configuration?

In case someone has this parameter in a sitemap, the loading of the sitemap will then fail and an error will be logged.

As previously explained, I expect it should impact only a very minority of users, maybe few old OH users that created sitemaps many years ago and preferred Classic UI over Basic UI when Classic UI was still existing. This parameter was only for Classic UI.

By the way, we should add a breaking change notice in 4.3 release notes.

We still list sendFrequency as an allowed option in the documentation of 4.2.x. Or do I get something wrong?

We are now working on version 4.3 and this was already removed from documentation for this next version: openhab/openhab-docs#2346

[lolodomo]

@kaikreuzer : I would be in favour to not loose too much time with a 2 steps solution as this parameter is probably still used by nobody. A breaking change in the release notes seems to be sufficient IMHO.
I will not spend time on developing and testing a solution that will keep a backward compatibility with an additional log message. But I am also ok if someone wants to do it.

[kaikreuzer]

Ok, then please create a PR for the breaking change in the distro repo - thanks!

[lolodomo]

Ok, then please create a PR for the breaking change in the distro repo

Done