Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expiry] [expire] Expiry to ignore commands #2954

Merged
merged 4 commits into from
May 11, 2022

Conversation

ssalonen
Copy link
Contributor

@ssalonen ssalonen commented May 8, 2022

Resolves #2952

This needs an additional PR in UI to make it configurable via UI: openhab/openhab-webui#1388

ssalonen added 2 commits May 8, 2022 13:59
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Similar to ignoreStateUpdates parameter, this introduces new optional
parameter ignoreCommands.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@ssalonen ssalonen requested a review from a team as a code owner May 8, 2022 11:23
@ssalonen ssalonen changed the title Expire ignore commands [expiry] [expire] Expiry to ignore commands May 8, 2022
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@ssalonen ssalonen requested a review from J-N-K May 9, 2022 04:50
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@J-N-K J-N-K merged commit 09b9b33 into openhab:main May 11, 2022
@wborn wborn added this to the 3.3 milestone Jun 23, 2022
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* [expiry] [expire] bool configuration parameters parsing as util method
* [expiry] [expire] extend ExpiryManager to allow ignoring commands

Similar to ignoreStateUpdates parameter, this introduces new optional
parameter ignoreCommands.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
GitOrigin-RevId: 09b9b33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Expire to optionally ignore commands
3 participants