-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expiry] [expire] Expiry to ignore commands #2954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Similar to ignoreStateUpdates parameter, this introduces new optional parameter ignoreCommands. Signed-off-by: Sami Salonen <ssalonen@gmail.com>
ssalonen
changed the title
Expire ignore commands
[expiry] [expire] Expiry to ignore commands
May 8, 2022
J-N-K
requested changes
May 8, 2022
bundles/org.openhab.core/src/main/java/org/openhab/core/internal/items/ExpireManager.java
Show resolved
Hide resolved
bundles/org.openhab.core/src/main/java/org/openhab/core/internal/items/ExpireManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
J-N-K
reviewed
May 10, 2022
bundles/org.openhab.core/src/main/java/org/openhab/core/internal/items/ExpireManager.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
J-N-K
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM.
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* [expiry] [expire] bool configuration parameters parsing as util method * [expiry] [expire] extend ExpiryManager to allow ignoring commands Similar to ignoreStateUpdates parameter, this introduces new optional parameter ignoreCommands. Signed-off-by: Sami Salonen <ssalonen@gmail.com> GitOrigin-RevId: 09b9b33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2952
This needs an additional PR in UI to make it configurable via UI: openhab/openhab-webui#1388