Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ignore commands checkbox to expire metadata config #1388

Merged
merged 1 commit into from
May 10, 2022

Conversation

ssalonen
Copy link
Contributor

@ssalonen ssalonen commented May 8, 2022

Implement extra checkbox to match new ignoreCommands option for item expire functionality, as implemented in openhab/openhab-core#2954

Similar to #1325

Signed-off-by: Sami Salonen ssalonen@gmail.com

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@relativeci
Copy link

relativeci bot commented May 8, 2022

Job #392: Bundle Size — 10.71MB (-0.02%).

cca0451 vs 2b60fed

Changed metrics (5/10)
Metric Current Baseline
Initial JS 1.67MB(-0.02%) 1.67MB
Cache Invalidation 63.33% 60.61%
Chunks 218(-0.46%) 219
Assets 240(-0.41%) 241
Modules 1509(-0.07%) 1510
Changed assets by type (1/7)
            Current     Baseline
JS 8.65MB (-0.02%) 8.65MB

View Job #392 report on app.relative-ci.com

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, interesting feature, thanks!

@ghys ghys merged commit 3553ba7 into openhab:main May 10, 2022
@ghys
Copy link
Member

ghys commented May 10, 2022

...oops I didn't check that openhab/openhab-core#2954 wasn't merged yet. I suppose it will so this new UI option will do nothing until then, if it ends up not being merged as-is then we'll have to revert it 🤷

@ssalonen
Copy link
Contributor Author

ssalonen commented May 11, 2022

@ghys BTW, i noticed the existing description is a bit inaccurate

"If the ignore state updates checkbox is set, only state changes will reset the timer"

To my understanding, also commands will reset the timer

@ghys
Copy link
Member

ghys commented May 20, 2022

@ssalonen kindly submit a quick PR to update the description to make it accurate then, thanks!

@ghys ghys added enhancement New feature or request main ui Main UI labels May 29, 2022
@ghys ghys added this to the 3.3 milestone May 29, 2022
ssalonen added a commit to ssalonen/openhab-webui that referenced this pull request Jul 5, 2022
As discussed in
openhab#1388 (comment)

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
ghys pushed a commit that referenced this pull request Jul 6, 2022
As discussed in
#1388 (comment)

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants