-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ignore commands checkbox to expire metadata config #1388
Conversation
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Job #392: Bundle Size — 10.71MB (-0.02%).Changed metrics (5/10)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, interesting feature, thanks!
...oops I didn't check that openhab/openhab-core#2954 wasn't merged yet. I suppose it will so this new UI option will do nothing until then, if it ends up not being merged as-is then we'll have to revert it 🤷 |
@ghys BTW, i noticed the existing description is a bit inaccurate "If the ignore state updates checkbox is set, only state changes will reset the timer" To my understanding, also commands will reset the timer |
@ssalonen kindly submit a quick PR to update the description to make it accurate then, thanks! |
As discussed in openhab#1388 (comment) Signed-off-by: Sami Salonen <ssalonen@gmail.com>
As discussed in #1388 (comment) Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Implement extra checkbox to match new ignoreCommands option for item expire functionality, as implemented in openhab/openhab-core#2954
Similar to #1325
Signed-off-by: Sami Salonen ssalonen@gmail.com