Add default units for all dimensions #3143
Conversation
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
Use "Feet" for length unless having the default units close to the same size between SI and Imperial is important. If so use "Yard" which is closest to a meter in length. What I don't know is if it makes sense to provide imperial units for some of the more scientific units like acceleration, density, and the like. Everything else looks good. |
Signed-off-by: Jan N. Klug <github@klug.nrw>
|
@rkoshak For acceleration it probably makes sense, because we also have different units for speed. I'm not so sure about density, my guess would be that the most common use-case here is absolute humidity. What is the usual unit to express that? |
|
In all my years I've never been in a situation where I've ever used or seen absolute humidity used. It's affected by so many other variables it's not all that useful (IIRC). Beyond that I'm not sure where I've ever seen these in use day-to-day. Maybe in measuring how full a propane tank. I did some looking and it looks like pounds per cubic foot is most commonly used. I'm not sure what makes sense for acceleration. Since feet is the base unit we use I guess feet per second squared would make sense as a default here. I can't imagine in a home automation context where we'd care about acceleration in yards or miles per second squared by default. I've only ever encountered this sort of stuff in math and physics classes though and we used SI units even twenty-five years ago when I last took them. |
|
I guess we should leave it as we have it now. BTW: I use absolute humidity to check if it makes sense to use the bathroom fan. If the absolute humidity outside is higher than inside, don't turn it on even if the relative humidity is higher than the set value. |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/evcc-binding-electric-vehicle-charging-control/135209/19 |
| addDefaultUnit(ElectricInductance.class, Units.HENRY); | ||
| addDefaultUnit(ElectricPotential.class, Units.VOLT); | ||
| addDefaultUnit(ElectricResistance.class, Units.OHM); | ||
| addDefaultUnit(Energy.class, Units.JOULE); |
There was a problem hiding this comment.
Could it be this change causes all kind of channels that are kWh to display in J, which is not expected. Is there a fix possible?
There was a problem hiding this comment.
Could this mean %unit% should not be used in binding xml definitions anymore? Or is it a bug in core where if might be that if specified as %unit% the default takes precedence over the unit in the quantity type? (I haven't looked into the source code yet)
There was a problem hiding this comment.
Could be. However, there is no way to avoid that and it was always the case with the dimensions that had a default unit before.
The state description takes precedence over the default (and that works), so we could check if we need to adjust %unit%. I'll have a look.
There was a problem hiding this comment.
@J-N-K The difference to other dimensions is that this here now is a breaking change - many of my items now show J instead of KWh and even a couple of my rules are impacted. I assume @Hilbrand (and many others) have a similar situation.
I wonder whether we should maybe define kWh as a default for Energy - after all, this is the unit that is almost always used in a smart home context, while J is rather a very rare exception
Wdyt?
There was a problem hiding this comment.
@kaikreuzer for the channels with %unit% my issue was solved in #3201.
There was a problem hiding this comment.
While the J might be the standard unit I think in a home automation context kWhshould absolutely be the default.
99% of the time users want to compare/measure energy consumption of devices and that's typically done in kWh
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/uom-default-units-and-consequences/142360/67 |
* Add default units for all dimensions Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: d00d14d
Fixes #3150
Fixes #3121
Fixes #3096
It would be great if someone from the US could check if I did pick good units for the imperial measurement system or if something is missing there.
Signed-off-by: Jan N. Klug github@klug.nrw