Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align I18nProviderImpl and thing description XSD #4233

Merged
merged 1 commit into from
May 18, 2024
Merged

Align I18nProviderImpl and thing description XSD #4233

merged 1 commit into from
May 18, 2024

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented May 18, 2024

@J-N-K
Align I18nProviderImpl and thing description XSD
9f402ad 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of the Core critical labels May 18, 2024
@J-N-K J-N-K requested a review from a team as a code owner May 18, 2024 08:51
@holgerfriedrich
Copy link
Member

can you please double check the following types which do not occur in the whole core and add-ons repo:

Number:AmountOfSubstance
Number:CatalyticActivity
Number:Currency
Number:ElectricCapacitance
Number:ElectricConductance
Number:ElectricConductivity
Number:ElectricInductance
Number:Force
Number:LuminousFlux
Number:LuminousIntensity
Number:MagneticFlux
Number:MagneticFluxDensity
Number:RadioactiveActivity
Number:SolidAngle

The following types have an implementation in core, but are not found in add-ons:

Number:RadiationDoseAbsorbed
Number:RadiationDoseEffective

@J-N-K
Copy link
Member Author

J-N-K commented May 18, 2024

I only aligned the item-types to the supported units (i.e. those that have a default dimension). These were added in #3143, I can't remember exactly why I choose all those, but they are consistent with the list of supported dimensions here, so I guess we should not remove them.

holgerfriedrich
holgerfriedrich approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@holgerfriedrich holgerfriedrich merged commit 73f4722 into openhab:main May 18, 2024
5 checks passed
@holgerfriedrich holgerfriedrich added this to the 4.2 milestone May 18, 2024
@J-N-K J-N-K deleted the xsd branch May 18, 2024 11:08
kaikreuzer added a commit to openhab/website that referenced this pull request May 18, 2024
@kaikreuzer
Update thing-description-1.0.0.xsd
7322789 
See openhab/openhab-core#4233

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer mentioned this pull request May 18, 2024
Merged
kaikreuzer added a commit to openhab/website that referenced this pull request May 18, 2024
@kaikreuzer
Update thing-description-1.0.0.xsd (#462)
c84d358 
See openhab/openhab-core#4233

Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer
Copy link
Member

I've updated the website accordingly with openhab/website#462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerfriedrich holgerfriedrich holgerfriedrich approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of the Core critical
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@J-N-K @holgerfriedrich @kaikreuzer