Allow inline scripts in SCRIPT transformation

[J-N-K]

Closes #3243

Inline scripts are identified by starting with | which is fine since that is neither an allowed character on nearly all file systems nor for UIDs. Additionally, the old JS transformation also defined inline scripts in this way, so it is already a known concept.

Signed-off-by: Jan N. Klug github@klug.nrw

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/93

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-milestone-discussion/145133/21

[J-N-K]

SCRIPT(dsl:|input.length):%s works fine

[wborn]

Thanks! It will be even more useful now you can use this with any scripting language. 🙂

[dandjo]

Not working with SCRIPT(js:my_script.script):%s, as it did with MS1. But JS(my_script.script):%s is back.
Should be documented somewhere.

[rkoshak]

But JS(my_script.script):%s is back.
Should be documented somewhere.

It's mentioned on the milestone thread (https://community.openhab.org/t/openhab-4-0-milestone-discussion/145133/186), the snapshot thread (https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/320), and the docs have been updated (https://next.openhab.org/docs/configuration/transformations.html#script-transformation).

[dandjo]

Thanks Richard. A short list of breaking changes here migrating from 4.0.0-M1 or 3.4.X would be great. Would have saved me hours of work trying to figure out why SCRIPT(js:foobar.script) stopped working.

[rkoshak]

The PR that made the change is listed there though. It's #3292.

For the milestones I believe the release notes are completely auto generated from the titles of the issues/prs. I'm not sure there is a place/opportunity to add a custom list of breaking changes for a milestone release.

And then you have to ask is the list breaking changes from M1 or breaking changes from 3.4.2? If the latter, this update actually reverses a breaking change instead of reintroducing one.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/preparation-for-oh-4-0-how-to-find-my-js-transformations/146233/5