Introduce a profile for the generic SCRIPT transformation #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-N-K
force-pushed
the
feature-scriptingprofile
branch
from
a625a3b to
bc2da59
Compare
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/93 |
9 tasks
|
Can you have another look at this @kaikreuzer? |
wborn
changed the title
kaikreuzer
requested changes
Mar 20, 2023
...ipt/src/main/java/org/openhab/core/automation/module/script/ScriptTransformationService.java
Outdated
Show resolved
Hide resolved
...le.script/src/main/java/org/openhab/core/automation/module/script/profile/ScriptProfile.java
Show resolved
Hide resolved
...le.script/src/main/java/org/openhab/core/automation/module/script/profile/ScriptProfile.java
Show resolved
Hide resolved
...le.script/src/main/java/org/openhab/core/automation/module/script/profile/ScriptProfile.java
Outdated
Show resolved
Hide resolved
...le.script/src/main/java/org/openhab/core/automation/module/script/profile/ScriptProfile.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan N. Klug <github@klug.nrw>
J-N-K
force-pushed
the
feature-scriptingprofile
branch
from
bc2da59 to
16a480f
Compare
Signed-off-by: Jan N. Klug <github@klug.nrw>
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Introduce a generic script profile Signed-off-by: Jan N. Klug <github@klug.nrw> GitOrigin-RevId: 7bad9ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #2872 which for unknown reasons can't be re-opened. I did another check and found that a general TRANSFORM profile is not feasible without a nearly complete refactoring of the whole transformation infrastructure. It would also need extensive refactoring in the UI part which I can't do.