Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove author from addon xsd #3362

Merged
merged 3 commits into from
Feb 11, 2023
Merged

Remove author from addon xsd #3362

merged 3 commits into from
Feb 11, 2023

Conversation

kaikreuzer
Copy link
Member

See #3050 (comment)

Signed-off-by: Kai Kreuzer kai@openhab.org

@kaikreuzer
Remove author from addon xsd
282ac56 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer requested a review from a team as a code owner February 8, 2023 18:11
@J-N-K
Copy link
Member

J-N-K commented Feb 8, 2023

I think it should also be removed from org.openhab.core.addon.AddonInfo and the parsing should be removed from org.openhab.core.addon.xml.internal.AddonInfoConverter and org.openhab.core.addon.xml.internal.AddonInfoReader.

@jlaur
Copy link
Contributor

jlaur commented Feb 8, 2023

FYI, addons should be ready for this: openhab/openhab-addons#14333

@kaikreuzer
Addressed review feedback
cd0bba3 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
This was referenced Feb 9, 2023
Merged
Merged
@kaikreuzer
Copy link
Member Author

@jlaur Thanks! At least almost all bindings should be ready, see openhab/org.openhab.binding.zwave#1843 and openhab/org.openhab.binding.zigbee#795. 😉

@kaikreuzer
Further cleanup
6c9d5fb 
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@kaikreuzer kaikreuzer requested a review from J-N-K February 10, 2023 13:43
J-N-K
J-N-K approved these changes Feb 11, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@J-N-K J-N-K merged commit 304617c into openhab:main Feb 11, 2023
@J-N-K J-N-K added this to the 4.0 milestone Feb 11, 2023
@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Feb 11, 2023
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/167

@rkoshak rkoshak mentioned this pull request Feb 14, 2023
Closed
@kaikreuzer kaikreuzer mentioned this pull request Feb 16, 2023
Merged
@jlaur jlaur mentioned this pull request Mar 27, 2023
Merged
@jlaur jlaur mentioned this pull request Apr 18, 2023
Merged
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@kaikreuzer @splatch
Remove author from addon xsd (openhab#3362)
d5e4b12 
* Remove author from addon xsd

Signed-off-by: Kai Kreuzer <kai@openhab.org>
GitOrigin-RevId: 304617c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kaikreuzer @J-N-K @jlaur @openhab-bot