Redefine connection in addon.xsd #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
|
I have prepared openhab/openhab-addons#14845 in case this pull request will be accepted, since |
|
Shouldn't there also be a PR to the UI, adding these options to filter the bindings? |
You might be right, I did not know anything was implemented in the UI yet, can you point me to where this can be seen? |
wborn
reviewed
Apr 20, 2023
There was a problem hiding this comment.
Can you also create a PR to update https://github.com/openhab/website/blob/main/.vuepress/public/schemas/addon-1.0.0.xsd ?
|
@wborn - thanks for the reference! Done. |
kaikreuzer
approved these changes
Apr 20, 2023
This was referenced Apr 20, 2023
splatch
pushed a commit
to ConnectorIO/copybara-hab-core
that referenced
this pull request
Jul 12, 2023
* Redefine addon.xml connection * Remove remains of author Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk> GitOrigin-RevId: 4349be6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redefines
connectionin addon.xsd by:nonefor no interactions with external systems at all (e.g. astro)cloudDiscoverybyhybridwhich is more generic and can be used when internet access is not required, but can provide optional extended functionality (for example discovery).Also includes a commit with a very small cleanup after #3362.
Resolves #3555