Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use setpoint as default sitemap element for item with tag "Setpoint" #3364

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Use setpoint as default sitemap element for item with tag "Setpoint" #3364

merged 2 commits into from
Feb 12, 2023

Conversation

lolodomo
Copy link
Contributor

Fix openhab/openhab-webui#1697

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo requested a review from a team as a code owner February 12, 2023 09:31
@lolodomo
Copy link
Contributor Author

Using these items!

Group GTest "Group for tests"

Number:Temperature CurrentTemp "Current Temp [%.1f °C]" <temperature> (GTest) [ "Measurement", "Temperature" ]
Number:Temperature SetpointTemp "Setpoint Temp [%.1f °C]" <temperature> (GTest) [ "Setpoint", "Temperature" ]

and this sitemap:

sitemap test label="Tests"
{
        Frame {
                Default item=CurrentTemp
                Default item=SetpointTemp
                Group item=GTest
        }
}

Before this PR, the rendering was like that:
image
image
It is now:
image
image

@lolodomo
Review comment: rather define a hasItemTag method
bb87214 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
J-N-K
J-N-K approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@J-N-K J-N-K merged commit fd6e161 into openhab:main Feb 12, 2023
@J-N-K J-N-K added this to the 4.0 milestone Feb 12, 2023
@J-N-K J-N-K added enhancement An enhancement or new feature of the Core UI User Interface labels Feb 12, 2023
@lolodomo lolodomo deleted the default_setpoint branch February 12, 2023 19:27
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
@lolodomo @splatch
Use setpoint as default sitemap element for item with tag "Setpoint" (o…
358ee67 
…penhab#3364)

* Use setpoint as default sitemap element for item with tag "Setpoint"

Fix openhab/openhab-webui#1697

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
GitOrigin-RevId: fd6e161
@lolodomo lolodomo mentioned this pull request Sep 10, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core UI User Interface
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Setpoint/Control items used in sitemaps as default or in groups should generate slider/stepper widget
2 participants
@lolodomo @J-N-K